From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21007 invoked by alias); 12 May 2014 17:46:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20998 invoked by uid 89); 12 May 2014 17:46:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 May 2014 17:46:09 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4CHk7IE032285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 May 2014 13:46:07 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-63.phx2.redhat.com [10.3.113.63]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4CHk7TA007584; Mon, 12 May 2014 13:46:07 -0400 Message-ID: <537108DF.3010504@redhat.com> Date: Mon, 12 May 2014 17:46:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 39/89] Introduce gimple_omp_parallel References: <1398099480-49147-1-git-send-email-dmalcolm@redhat.com> <1398099480-49147-40-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1398099480-49147-40-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00827.txt.bz2 On 04/21/14 10:57, David Malcolm wrote: > gcc/ > * coretypes.h (gimple_omp_parallel): New typedef. > (const_gimple_omp_parallel): New typedef. > > * cgraphbuild.c (build_cgraph_edges): Convert check of code > against GIMPLE_OMP_PARALLEL to a dyn_cast_gimple_omp_parallel and > new local. > > * gimple-pretty-print.c (dump_gimple_omp_parallel): Require a > gimple_omp_parallel rather than a plain gimple. > (pp_gimple_stmt_1): Add a checked cast to gimple_omp_parallel > within GIMPLE_OMP_PARALLEL case of switch statement. > > * gimple-walk.c (walk_gimple_op): Likewise, introducing a local. > > * gimple.c (gimple_build_omp_parallel): Return a > gimple_omp_parallel rather than a plain gimple. > (gimple_copy): Add checked casts to gimple_omp_parallel within > GIMPLE_OMP_PARALLEL case of switch statement, introducing locals. > > * gimple.h (gimple_statement_base::as_a_gimple_omp_parallel): New. > (gimple_statement_base::dyn_cast_gimple_omp_parallel): New. > (gimple_build_omp_parallel): Return a gimple_omp_parallel rather > than a plain gimple. > (gimple_omp_parallel_clauses_ptr): Require a gimple_omp_parallel > rather than a plain gimple. > (gimple_omp_parallel_set_clauses): Likewise. > (gimple_omp_parallel_data_arg_ptr): Likewise. > (gimple_omp_parallel_set_data_arg): Likewise. > (gimple_omp_parallel_child_fn_ptr): Likewise. > (gimple_omp_parallel_set_child_fn): Likewise. > (gimple_omp_parallel_child_fn): Require a > const_gimple_omp_parallel rather than a plain const_gimple. > (gimple_omp_parallel_data_arg): Likewise. > > * omp-low.c (scan_omp_parallel): Strengthen local "stmt" from > gimple to gimple_omp_parallel. > (expand_parallel_call): Require a gimple_omp_parallel for > "entry_stmt" rather than a plain gimple. > (remove_exit_barrier): Strengthen local "parallel_stmt" from > gimple to gimple_omp_parallel. > (expand_omp_taskreg): Add checked cast to gimple_omp_parallel. > > * tree-inline.c (remap_gimple_stmt): Add a checked cast to > gimple_omp_parallel within GIMPLE_OMP_PARALLEL case of switch > statement, introducing local. > --- OK with expected changes due to renaming/updates to const handling. Please repost the final patch for archival purposes. jeff