From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27492 invoked by alias); 13 May 2014 14:17:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27467 invoked by uid 89); 13 May 2014 14:17:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GARBLED_BODY,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ee0-f41.google.com Received: from mail-ee0-f41.google.com (HELO mail-ee0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 13 May 2014 14:17:43 +0000 Received: by mail-ee0-f41.google.com with SMTP id t10so473123eei.0 for ; Tue, 13 May 2014 07:17:40 -0700 (PDT) X-Received: by 10.14.53.66 with SMTP id f42mr4460802eec.70.1399990660368; Tue, 13 May 2014 07:17:40 -0700 (PDT) Received: from [192.168.1.12] (ppp-94-65-208-204.home.otenet.gr. [94.65.208.204]) by mx.google.com with ESMTPSA id 4sm40511186eeq.33.2014.05.13.07.17.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 13 May 2014 07:17:38 -0700 (PDT) Message-ID: <53722A54.9070604@gmail.com> Date: Tue, 13 May 2014 14:17:00 -0000 From: Dimitris Papavasiliou User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Mike Stump CC: "gcc-patches@gcc.gnu.org Patches" Subject: Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope References: <52F35508.4080205@gmail.com> <5486E33D-B8F6-473F-8F33-6A7DEECB45A8@comcast.net> <5359999C.7090607@gmail.com> <757BB622-2CA8-4C9A-BCA9-AAD1FDF8F14F@comcast.net> <535A8EA8.5040706@gmail.com> <80E7465A-6FE8-475D-873E-FF2F2C8EC2ED@comcast.net> <535E2EF9.3070500@gmail.com> <2AE8F880-6ACF-42F8-9736-2268E3CCE9A4@comcast.net> In-Reply-To: <2AE8F880-6ACF-42F8-9736-2268E3CCE9A4@comcast.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00976.txt.bz2 On 05/12/2014 11:53 PM, Mike Stump wrote: > I put in one small fix: > > Doing diffs in testsuite/objc.dg/ivar-visibility-4.m.~1~: > --- testsuite/objc.dg/ivar-visibility-4.m.~1~ 2014-05-12 12:04:16.000000000 -0700 > +++ testsuite/objc.dg/ivar-visibility-4.m 2014-05-12 13:50:53.000000000 -0700 > @@ -29,7 +29,7 @@ > { > int a; > > - /* someivar is public so we shoudn't get any errors here. */ > + /* someivar is public so we shouldn't get any errors here. */ > > a = object->someivar; > } > ——————— > > Ok, thanks for that and for all your help in general. I tried checking out the current master branch and running objective-c and objective-c++ related tests and everything seems to be in order so hopefully that concludes the business with this patch. Dimitris