From: Nicholas Clifton <nickc@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFA: Fix calculation of size of builtin setjmp buffer
Date: Wed, 14 May 2014 13:32:00 -0000 [thread overview]
Message-ID: <53737067.2030608@redhat.com> (raw)
In-Reply-To: <3114307.feqyCiYPCg@polaris>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
Hi Eric,
>> 2014-05-06 Nick Clifton <nickc@redhat.com>
>>
>> * except.c (init_eh): Fix computation of builtin setjmp buffer
>> size.
>
> That's the same patch as
> https://gcc.gnu.org/ml/gcc-patches/2011-11/msg00272.html
> and is still incorrect.
Ah - you are worried about the case where STACK_SAVEAREA_MODE() is
smaller than Pmode, yes ?
OK then, how about this revised version of the patch where the size
computation is now:
tmp = size_int (MAX (GET_MODE_SIZE (STACK_SAVEAREA_MODE
(SAVE_NONLOCAL))
/ GET_MODE_SIZE (Pmode), 1)
+ 2 /* Stack pointer and frame pointer. */
+ 1 /* Slop for mips. */
- 1);
OK to apply ?
Cheers
Nick
[-- Attachment #2: except.c.patch.4 --]
[-- Type: application/x-troff-man, Size: 4663 bytes --]
next prev parent reply other threads:[~2014-05-14 13:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 12:55 Nick Clifton
2014-05-06 13:15 ` Jakub Jelinek
2014-05-06 14:34 ` Nicholas Clifton
2014-05-06 14:38 ` Richard Biener
2014-05-06 14:40 ` Jakub Jelinek
2014-05-06 15:07 ` Nicholas Clifton
2014-05-06 20:17 ` Mike Stump
2014-05-08 14:25 ` Nicholas Clifton
2014-05-08 16:08 ` Mike Stump
2014-05-14 8:23 ` Eric Botcazou
2014-05-14 8:17 ` Eric Botcazou
2014-05-14 13:32 ` Nicholas Clifton [this message]
2014-05-15 7:56 ` Eric Botcazou
2014-05-15 14:49 ` Mike Stump
2014-05-16 16:56 ` Eric Botcazou
2014-05-16 8:29 ` Nicholas Clifton
2014-05-16 16:57 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53737067.2030608@redhat.com \
--to=nickc@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).