From: "Saraswati, Sujoy (OSTL)" <sujoy.saraswati@hpe.com>
To: Joseph Myers <joseph@codesourcery.com>,
Sujoy Saraswati <ssaraswati@gmail.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: RE: Fix 61441
Date: Thu, 26 Nov 2015 08:28:00 -0000 [thread overview]
Message-ID: <5379BA8D7E9D7E4D87BF6749A92854C248FC9093@G4W3297.americas.hpqcorp.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1511061301390.10753@digraph.polyomino.org.uk>
Hi,
> I think the general principle is:
>
> * The caller decides whether folding is desirable (whether it would lose
> exceptions, for example).
>
> * The real.c code is called only when the caller has decided that folding is
> desirable, and should always produce the correct output (which for a
> conversion means producing a quiet NaN from a signaling NaN).
>
> So both places need changes, but real_convert is where the code that makes
> it a quiet NaN should go.
>
> Another place in the patch that looks incorrect: the changes to fold-const-
> call.c calling real_powi and checking if the result is a signaling NaN. The result
> of real_powi should never be a signaling NaN.
> Rather, real_powi should produce a quiet NaN if its input is a signaling NaN,
> and the callers should check if the argument is a signaling NaN when deciding
> whether to fold, not if the result is.
I made the changes accordingly and will post the patches now.
Regards,
Sujoy
> --
> Joseph S. Myers
> joseph@codesourcery.com
prev parent reply other threads:[~2015-11-26 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 10:23 Sujoy Saraswati
2015-09-01 12:21 ` Richard Biener
2015-09-02 11:36 ` Sujoy Saraswati
2015-09-02 11:56 ` Richard Biener
2015-09-02 12:16 ` Sujoy Saraswati
2015-09-10 7:33 ` Sujoy Saraswati
2015-09-14 13:50 ` Richard Biener
2015-09-14 20:39 ` Joseph Myers
2015-09-16 13:01 ` Sujoy Saraswati
2015-09-16 17:03 ` Joseph Myers
2015-10-13 10:46 ` Sujoy Saraswati
2015-10-28 17:19 ` Joseph Myers
2015-11-05 11:29 ` Sujoy Saraswati
2015-11-05 16:58 ` Joseph Myers
2015-11-06 4:56 ` Sujoy Saraswati
2015-11-06 13:09 ` Joseph Myers
2015-11-26 8:28 ` Saraswati, Sujoy (OSTL) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5379BA8D7E9D7E4D87BF6749A92854C248FC9093@G4W3297.americas.hpqcorp.net \
--to=sujoy.saraswati@hpe.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=richard.guenther@gmail.com \
--cc=ssaraswati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).