From: "Martin Liška" <mliska@suse.cz>
To: Jeff Law <law@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/4] Remove unused functions and fields.
Date: Tue, 25 Sep 2018 07:18:00 -0000 [thread overview]
Message-ID: <5386add0-0af1-d604-96e6-dab0e565924b@suse.cz> (raw)
In-Reply-To: <43d7b949-b909-6c5a-866a-d7a8f56e26b2@redhat.com>
On 9/24/18 4:42 PM, Jeff Law wrote:
> On 9/22/18 1:08 PM, marxin wrote:
>>
>> gcc/ChangeLog:
>>
>> 2018-09-24 Martin Liska <mliska@suse.cz>
>>
>> * alias.c (set_dest_equal_p): Remove unused function.
>> * config/i386/i386.c (def_builtin_pure2): Likewise.
>> * diagnostic-show-locus.c (class layout): Remove
>> unused field.
>> (layout::layout): Likewise here.
>> * dump-context.h (class temp_dump_context): Likewise.
>> * dwarf2out.c (add_AT_fde_ref): Remove unused function.
>> (add_AT_loclistsptr): Likewise.
>> (add_AT_offset): Likewise.
>> (get_AT_hi_pc): Likewise.
>> (is_comdat_die): Likewise.
>> (type_is_enum): Likewise.
>> (ceiling): Likewise.
>> (add_AT_vms_delta): Likewise.
>> (is_class_die): Likewise.
>> * edit-context.c (class line_event): Remove unused field.
>> * graphite-sese-to-poly.c (tree_int_to_gmp): Remove
>> unused function.
>> * ipa-cp.c (ipa_get_vr_lat): Likewise.
>> * lra-constraints.c (ok_for_index_p_nonstrict): Likewise.
>> (ok_for_base_p_nonstrict): Likewise.
>> * tree-chrec.c (is_not_constant_evolution): Likewise.
>> (chrec_fold_poly_cst): Likewise.
>> * tree-if-conv.c (has_pred_critical_p): Likewise.
>> * tree-ssa-coalesce.c (print_exprs): Likewise.
>> * tree-ssa-pre.c (bitmap_set_contains_expr): Likewise.
>> * tree-ssa-uninit.c (is_and_or_or_p): Likewise.
>> * tree-vrp.c (value_ranges_intersect_p): Likewise.
>> (value_range_nonnegative_p): Likewise.
>>
>> gcc/cp/ChangeLog:
>>
>> 2018-09-24 Martin Liska <mliska@suse.cz>
>>
>> * name-lookup.c (namespace_scope_ht_size): Remove
>> unused function.
>> * parser.c (cp_lexer_next_token_is_not_keyword): Likewise.
>>
>> gcc/fortran/ChangeLog:
>>
>> 2018-09-24 Martin Liska <mliska@suse.cz>
>>
>> * trans.c (remove_suffix): Remove
>> unused function.
>>
>> gcc/go/ChangeLog:
>>
>> 2018-09-24 Martin Liska <mliska@suse.cz>
>>
>> * gofrontend/escape.cc (Gogo::analyze_escape): Remove
>> usage of a parameter.
>> (Gogo::assign_connectivity): Likewise.
>> (class Escape_analysis_tag): Likewise.
>> (Gogo::tag_function): Likewise.
>> * gofrontend/expressions.cc (Call_expression::do_type): Likewise.
>> * gofrontend/gogo.h (class Gogo): Likewise.
>> * gofrontend/types.cc (class Call_multiple_result_type): Likewise.
>> (Type::make_call_multiple_result_type): Likewise.
>> * gofrontend/types.h (class Type): Likewise.
>> * gofrontend/wb.cc (class Check_escape): Likewise.
>> (Gogo::add_write_barriers): Likewise.
> Note that some of these may be used inside conditional code. For
> example the add_AT_vms_delta is used by ia64-vms. You could argue that
> ia64-vms is a zombie and should be removed, but the general concern WRT
> conditionally compiled code holds.
Well, please let me install the patch as is and if somebody will need the
functionality, I would be happy to put it back.
Thanks,
Martin
>
> Jeff
>
next prev parent reply other threads:[~2018-09-25 7:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 7:37 [PATCH 0/4] Clean-up warnings spotted by Rtags marxin
2018-09-24 7:37 ` [PATCH 1/4] Add filter-rtags-warnings.py script marxin
2018-09-24 14:45 ` Jeff Law
2018-09-24 7:37 ` [PATCH 4/4] Fix scaling of a sreal number marxin
2018-09-24 14:42 ` Jeff Law
2018-09-24 7:37 ` [PATCH 3/4] Fix small coding style issues (PR fortran/87394) marxin
2018-09-24 14:39 ` Jeff Law
2018-09-24 7:39 ` [PATCH 2/4] Remove unused functions and fields marxin
2018-09-24 14:42 ` Jeff Law
2018-09-25 7:18 ` Martin Liška [this message]
2018-09-25 12:31 ` Richard Biener
2018-09-25 13:40 ` Jeff Law
2018-09-26 9:01 ` Martin Liška
2018-09-27 11:18 ` Bernhard Reutner-Fischer
2018-10-03 16:46 ` Jeff Law
2018-10-03 19:35 ` Bernhard Reutner-Fischer
2018-10-05 2:19 ` Bernhard Reutner-Fischer
2018-10-05 13:41 ` Martin Liška
2018-10-09 8:52 ` [PATCH] Remove dead functions and fix VMS target by moving back some functions Martin Liška
2018-10-09 22:53 ` Martin Jambor
2018-10-10 11:13 ` Martin Liška
2018-10-10 11:17 ` Martin Jambor
2018-10-18 23:55 ` [PATCH 2/4] Remove unused functions and fields Ian Lance Taylor
2018-10-22 13:05 ` Martin Liška
2018-10-22 17:50 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386add0-0af1-d604-96e6-dab0e565924b@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).