From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26355 invoked by alias); 30 May 2014 17:10:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26323 invoked by uid 89); 30 May 2014 17:10:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 May 2014 17:10:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4UHAGqD018626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 May 2014 13:10:16 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-20.phx2.redhat.com [10.3.113.20]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4UHAGeE027998; Fri, 30 May 2014 13:10:16 -0400 Message-ID: <5388BB78.5080703@redhat.com> Date: Fri, 30 May 2014 17:10:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Ilya Enkovich , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, i386, Pointer Bounds Checker 10/x] Partitions References: <20140528104154.GA18451@msticlxl57.ims.intel.com> In-Reply-To: <20140528104154.GA18451@msticlxl57.ims.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg02632.txt.bz2 On 05/28/14 10:06, Ilya Enkovich wrote: > Hi, > > This patch keeps instrumented and original versions together and preserve tranparent alias chain during symbol name privatization. > > Bootstrapped and tested on linux-x86_64. > > Thanks, > Ilya > -- > gcc/ > > 2013-05-28 Ilya Enkovich > > * lto/lto-partition.c (add_symbol_to_partition_1): Keep original > and instrumented versions together. This part is OK. Note lto/ has its own ChangeLog, so put the ChangeLog entry there and don't use the "lto/" prefix in the ChangeLog entry. > (privatize_symbol_name): Restore transparent alias chain if required. What exactly are you doing here? The comment in the code doesn't really make it clear what you are doing or why. > + /* We could change name which is a target of transparent alias > + chain of instrumented function name. Fix alias chain if so .*/ So are you saying that we want to change the name? Or that it could have been changed and we have to adjust something because it was changed? I'm certainly not as familiar with the LTO stuff as I should be -- what is the purpose behing chaining the DECL_ASSEMBLER_NAME nodes? jeff