From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>,
Alexandre Oliva <aoliva@redhat.com>,
Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] contrib: Fill in HOST{CC,CFLAGS,CXX,CXXFLAGS} in test_installed
Date: Mon, 5 Feb 2024 09:07:43 -0700 [thread overview]
Message-ID: <538ab469-5d7f-4eb2-8399-b8565e39b5f1@gmail.com> (raw)
In-Reply-To: <ZcDnilo9xkjaDa/u@tucnak>
On 2/5/24 06:50, Jakub Jelinek wrote:
> Hi!
>
> gcc/Makefile.in since my r0-60234 change fills in HOSTCC and HOSTCFLAGS
> in site.exp and since r8-671 also HOSTCXX and HOSTCXXFLAGS.
> If those variables aren't set, we get errors like:
> /usr/src/gcc/contrib/test_installed --without-g++ --without-gfortran --without-objc struct-layout-1.exp
> ...
> ERROR: tcl error sourcing /usr/src/gcc/gcc/testsuite/gcc.dg/compat/struct-layout-1.exp.
> ERROR: tcl error code TCL LOOKUP VARNAME HOSTCC
> ERROR: can't read "HOSTCC": no such variable
> while executing
> "remote_exec build "$HOSTCC $HOSTCFLAGS $generator_cmd""
> (file "/usr/src/gcc/gcc/testsuite/gcc.dg/compat/struct-layout-1.exp" line 96)
> invoked from within
> "source /usr/src/gcc/gcc/testsuite/gcc.dg/compat/struct-layout-1.exp"
> ("uplevel" body line 1)
> invoked from within
> "uplevel #0 source /usr/src/gcc/gcc/testsuite/gcc.dg/compat/struct-layout-1.exp"
> invoked from within
> "catch "uplevel #0 source $test_file_name" msg"
>
> (similarly in g++ or gfortran) struct-layout-1.exp. One doesn't need to
> test specially for just struct-layout-1.exp alone, just not using any arg
> will trigger it as well, just later.
>
> The following patch fills it in as cc and c++ with empty flags to compile
> those, I believe that is what e.g. make uses by default, so it should be a
> reasonable default. We IMHO shouldn't default to GCC_UNDER_TEST because
> that might be a cross-compiler etc.
>
> Ok for trunk?
>
> 2024-02-05 Jakub Jelinek <jakub@redhat.com>
>
> * test_installed: Fill in HOSTCC, HOSTCXX, HOSTCFLAGS and
> HOSTCXXFLAGS.
Ugh. test_installed :( Probably a necessary evil, though I suspect few
people are using it. So if it works for the scenarios you're testing,
then OK by me.
jeff
next prev parent reply other threads:[~2024-02-05 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:50 Jakub Jelinek
2024-02-05 16:07 ` Jeff Law [this message]
2024-02-06 5:12 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538ab469-5d7f-4eb2-8399-b8565e39b5f1@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).