public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robin Dapp <rdapp.gcc@gmail.com>
To: Edwin Lu <ewlu@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, gnu-toolchain@rivosinc.com
Subject: Re: [PATCH V3 2/4] RISC-V: Add vector related pipelines
Date: Thu, 25 Jan 2024 18:06:24 +0100	[thread overview]
Message-ID: <539cd8a1-a7e2-4592-90a5-35a486c97f43@gmail.com> (raw)
In-Reply-To: <20240112180844.2005246-3-ewlu@rivosinc.com>

Thanks, that looks better IMHO.

> +;; Copyright (C) 2011-2024 Free Software Foundation, Inc.
> +;; Contributed by Andrew Waterman (andrew@sifive.com).
> +;; Based on MIPS target for GNU compiler.

You might want to change that, as well as the date.  While at
it you can also fix the broken date in my original file ;)

> +(define_insn_reservation "vec_load" 6
> +  (and (eq_attr "is_inorder" "no")
> +       (eq_attr "type" "vlde,vldm,vlds,vldux,vldox,vldff,vldr"))
> +  "vxu_ooo_issue,vxu_ooo_alu")

I would rather ditch the is_inorder attribute for now and define
"low" latencies as well as reservations explicitly once we're
sure rather than falling back to scheduler defaults. 

OK with those changes.

Regards
 Robin

  reply	other threads:[~2024-01-25 17:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 18:08 [PATCH V3 0/4] RISC-V: Associate typed insns to dfa reservation Edwin Lu
2024-01-12 18:08 ` [PATCH V3 1/4] RISC-V: Add non-vector types to dfa pipelines Edwin Lu
2024-01-25 17:06   ` Robin Dapp
2024-02-01  1:41     ` [COMMITTED " Edwin Lu
2024-02-01  1:41       ` Edwin Lu
2024-01-12 18:08 ` [PATCH V3 2/4] RISC-V: Add vector related pipelines Edwin Lu
2024-01-25 17:06   ` Robin Dapp [this message]
2024-01-26 18:25     ` Edwin Lu
2024-01-30 19:39       ` Robin Dapp
2024-01-12 18:08 ` [PATCH V3 3/4] RISC-V: Use default cost model for insn scheduling Edwin Lu
2024-01-25 17:06   ` Robin Dapp
2024-01-26 18:31     ` Edwin Lu
2024-01-26 18:31       ` Edwin Lu
2024-02-01  1:41     ` [COMMITTED " Edwin Lu
2024-02-01  1:41       ` Edwin Lu
2024-01-12 18:08 ` [PATCH V3 4/4] RISC-V: Enable assert for insn_has_dfa_reservation Edwin Lu
2024-01-25 17:06   ` Robin Dapp
2024-01-26 18:37     ` Edwin Lu
2024-01-26 18:37       ` Edwin Lu
2024-02-01  1:42     ` [COMMITTED " Edwin Lu
2024-02-01  1:42       ` Edwin Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539cd8a1-a7e2-4592-90a5-35a486c97f43@gmail.com \
    --to=rdapp.gcc@gmail.com \
    --cc=ewlu@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).