From: Jeff Law <law@redhat.com>
To: mliska <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Cc: hubicka@ucw.cz
Subject: Re: [PATCH 4/5] Existing tests fix
Date: Tue, 17 Jun 2014 19:52:00 -0000 [thread overview]
Message-ID: <53A09C7A.9000001@redhat.com> (raw)
In-Reply-To: <6c7ae6475c2a98900d53a52392dc18c12f986347.1402913001.git.mliska@suse.cz>
On 06/13/14 04:48, mliska wrote:
> Hi,
> many tests rely on a precise number of scanned functions in a dump file. If IPA ICF decides to merge some function and(or) read-only variables, counts do not match.
>
> Martin
>
> Changelog:
>
> 2014-06-13 Martin Liska <mliska@suse.cz>
> Honza Hubicka <hubicka@ucw.cz>
>
> * c-c++-common/rotate-1.c: Text
> * c-c++-common/rotate-2.c: New test.
> * c-c++-common/rotate-3.c: Likewise.
> * c-c++-common/rotate-4.c: Likewise.
> * g++.dg/cpp0x/rv-return.C: Likewise.
> * g++.dg/cpp0x/rv1n.C: Likewise.
> * g++.dg/cpp0x/rv1p.C: Likewise.
> * g++.dg/cpp0x/rv2n.C: Likewise.
> * g++.dg/cpp0x/rv3n.C: Likewise.
> * g++.dg/cpp0x/rv4n.C: Likewise.
> * g++.dg/cpp0x/rv5n.C: Likewise.
> * g++.dg/cpp0x/rv6n.C: Likewise.
> * g++.dg/cpp0x/rv7n.C: Likewise.
> * gcc.dg/ipa/ipacost-1.c: Likewise.
> * gcc.dg/ipa/ipacost-2.c: Likewise.
> * gcc.dg/ipa/ipcp-agg-6.c: Likewise.
> * gcc.dg/ipa/remref-2a.c: Likewise.
> * gcc.dg/ipa/remref-2b.c: Likewise.
> * gcc.dg/pr46309-2.c: Likewise.
> * gcc.dg/torture/ipa-pta-1.c: Likewise.
> * gcc.dg/tree-ssa/andor-3.c: Likewise.
> * gcc.dg/tree-ssa/andor-4.c: Likewise.
> * gcc.dg/tree-ssa/andor-5.c: Likewise.
> * gcc.dg/vect/no-vfa-pr29145.c: Likewise.
> * gcc.dg/vect/vect-cond-10.c: Likewise.
> * gcc.dg/vect/vect-cond-9.c: Likewise.
> * gcc.dg/vect/vect-widen-mult-const-s16.c: Likewise.
> * gcc.dg/vect/vect-widen-mult-const-u16.c: Likewise.
> * gcc.dg/vect/vect-widen-mult-half-u8.c: Likewise.
> * gcc.target/i386/bmi-1.c: Likewise.
> * gcc.target/i386/bmi-2.c: Likewise.
> * gcc.target/i386/pr56564-2.c: Likewise.
> * g++.dg/opt/pr30965.C: Likewise.
> * g++.dg/tree-ssa/pr19637.C: Likewise.
> * gcc.dg/guality/csttest.c: Likewise.
> * gcc.dg/ipa/iinline-4.c: Likewise.
> * gcc.dg/ipa/iinline-7.c: Likewise.
> * gcc.dg/ipa/ipa-pta-13.c: Likewise.
I know this is the least interesting part of your changes, but it's also
simple and mechanical and thus trivial to review. Approved, but
obviously don't install until the rest of your patch has been approved.
Similar changes for recently added tests or cases where you might
improve ICF requiring similar tweaks to existing tests are pre-approved
as well.
jeff
next prev parent reply other threads:[~2014-06-17 19:52 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 10:07 [PATCH 1/5] New Identical Code Folding IPA pass mliska
2014-06-16 10:07 ` [PATCH 5/5] New tests introduction mliska
2014-06-17 19:53 ` Jeff Law
2014-06-30 12:14 ` Martin Liška
2014-10-19 8:19 ` Andreas Schwab
2014-10-23 12:34 ` Martin Liška
2014-06-16 10:07 ` [PATCH 2/5] Existing call graph infrastructure enhancement mliska
2014-06-17 20:00 ` Jeff Law
2014-06-30 11:49 ` Martin Liška
2014-06-30 18:54 ` Jeff Law
2014-07-17 14:54 ` Martin Liška
2014-08-25 9:56 ` Martin Liška
2014-08-25 16:12 ` Jan Hubicka
2014-08-27 21:12 ` Jeff Law
2014-09-24 14:23 ` Martin Liška
2014-09-24 15:01 ` Jan Hubicka
2014-09-26 10:19 ` Martin Liška
2014-06-16 10:07 ` [PATCH 3/5] IPA ICF pass mliska
2014-06-20 7:32 ` Trevor Saunders
2014-06-26 11:18 ` Martin Liška
2014-07-05 21:44 ` Gerald Pfeifer
2014-07-05 22:53 ` Jan Hubicka
2014-07-17 15:23 ` Martin Liška
2014-09-26 12:20 ` Martin Liška
2014-09-26 14:44 ` Markus Trippelsdorf
2014-09-26 23:27 ` Jan Hubicka
2014-09-27 5:59 ` Markus Trippelsdorf
2014-09-27 7:47 ` Markus Trippelsdorf
2014-09-27 10:46 ` Martin Liška
2014-09-27 10:37 ` Martin Liška
2014-09-28 2:21 ` Jan Hubicka
2014-10-10 23:54 ` Fakturace
2014-10-11 0:02 ` Martin Liška
2014-10-11 8:23 ` Jan Hubicka
2014-10-13 13:20 ` Martin Liška
2014-10-13 13:29 ` Jan Hubicka
2014-09-27 10:32 ` Martin Liška
2014-09-26 20:47 ` Jan Hubicka
2014-10-11 0:08 ` Martin Liška
2014-10-11 8:26 ` Jan Hubicka
2014-10-13 15:17 ` Martin Liška
2014-10-14 16:12 ` Jan Hubicka
2014-10-15 17:06 ` Martin Liška
2014-10-22 21:20 ` Jiong Wang
2014-11-06 3:01 ` Joey Ye
2014-11-06 9:03 ` Jan Hubicka
2014-11-13 22:26 ` H.J. Lu
2015-01-20 21:29 ` H.J. Lu
2014-09-26 22:27 ` Jan Hubicka
2014-10-11 0:23 ` Martin Liška
2014-10-11 9:05 ` Jan Hubicka
2014-06-24 20:31 ` Jeff Law
2014-06-26 16:02 ` Martin Liška
2014-06-26 18:46 ` Jan Hubicka
2014-06-30 12:05 ` Martin Liška
2014-07-01 23:45 ` Trevor Saunders
2014-06-30 19:06 ` Jeff Law
2014-06-16 10:07 ` [PATCH 4/5] Existing tests fix mliska
2014-06-17 19:52 ` Jeff Law [this message]
2014-06-17 20:50 ` Rainer Orth
2014-06-18 9:02 ` Martin Liška
2014-06-30 12:12 ` Martin Liška
2014-09-26 12:21 ` Martin Liška
2014-06-17 19:49 ` [PATCH 1/5] New Identical Code Folding IPA pass Jeff Law
2014-06-18 19:05 ` Jan Hubicka
2014-06-17 20:09 ` Paolo Carlini
2014-06-18 8:46 ` Martin Liška
2014-06-18 8:49 ` Paolo Carlini
2014-06-17 20:17 ` David Malcolm
2014-06-18 8:10 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A09C7A.9000001@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).