From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17820 invoked by alias); 17 Jun 2014 20:00:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17786 invoked by uid 89); 17 Jun 2014 20:00:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Jun 2014 20:00:08 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HK07ie020024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jun 2014 16:00:07 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-70.phx2.redhat.com [10.3.113.70]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HK06iA008207; Tue, 17 Jun 2014 16:00:06 -0400 Message-ID: <53A09E46.5080507@redhat.com> Date: Tue, 17 Jun 2014 20:00:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: mliska , gcc-patches@gcc.gnu.org CC: hubicka@ucw.cz Subject: Re: [PATCH 2/5] Existing call graph infrastructure enhancement References: <47303faf697c5f537d471e88d3c946c5a1d04f6e.1402913001.git.mliska@suse.cz> In-Reply-To: <47303faf697c5f537d471e88d3c946c5a1d04f6e.1402913001.git.mliska@suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg01388.txt.bz2 On 06/13/14 04:26, mliska wrote: > Hi, > this small patch prepares remaining needed infrastructure for the new pass. > > Changelog: > > 2014-06-13 Martin Liska > Honza Hubicka > > * ipa-utils.h (polymorphic_type_binfo_p): Function marked external > instead of static. > * ipa-devirt.c (polymorphic_type_binfo_p): Likewise. > * ipa-prop.h (count_formal_params): Likewise. > * ipa-prop.c (count_formal_params): Likewise. > * ipa-utils.c (ipa_merge_profiles): Be more tolerant if we merge > profiles for semantically equivalent functions. > * passes.c (do_per_function): If we load body of a function during WPA, > this condition should behave same. > * varpool.c (ctor_for_folding): More tolerant assert for variable > aliases created during WPA. Presumably we don't have any useful way to merge the cases where we have provides for SRC & DST in ipa_merge_profiles or even to guess which is more useful when presented with both? Does it make sense to log this into a debugging file when we drop one? I think this patch is fine. If adding logging makes sense, then feel free to do so and consider that trivial change pre-approved. Jeff