From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25100 invoked by alias); 17 Jun 2014 20:14:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25088 invoked by uid 89); 17 Jun 2014 20:14:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Jun 2014 20:14:24 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HKEMsk014669 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jun 2014 16:14:22 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-70.phx2.redhat.com [10.3.113.70]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HKELJJ019104; Tue, 17 Jun 2014 16:14:21 -0400 Message-ID: <53A0A19D.9050807@redhat.com> Date: Tue, 17 Jun 2014 20:14:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Kai Tietz CC: GCC Patches , Richard Henderson Subject: Re: [patch libatomic]: Add basic support for mingw targets References: <53A09423.5080601@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg01390.txt.bz2 On 06/17/14 13:31, Kai Tietz wrote: > 2014-06-17 21:16 GMT+02:00 Jeff Law : >> On 06/16/14 07:20, Kai Tietz wrote: >>> >>> Hello, >>> >>> this patch adds basic support for libatomic for mingw targets using >>> win32 and for mingw targets using posix threading model. >>> >>> The win32 implemenation might need for initialization of mutexes a >>> critical section. If issue occures we can still add that. For now >>> all testcases are passing for native and posix-threading model mingw >>> (32-bit and 64-bit). >>> >>> ChangeLog >>> >>> 2014-06-16 Kai Tietz >>> >>> * Makefile.am (libatomic_la_LDFLAGS): Add lt_host_flags. >> >> Isn't this all target stuff, in which case lt_host_flags seems >> inappropriate. Or is this just poorly named? > > Hmm, libatomic is here build for new host (means it is a gcc-target > library). So it might be named poorly. Nevertheless see for details > ACX_LT_HOST_FLAGS in config/lthostflags.m4 and why it is required to > set -no-undefined and the proper bindir for cygwin/mingw. Right, I'm aware that libatomic is a target library. What I'm worried about is confusion due to using ACX_LT_HOST_FLAGS and possible pollution of flags originally the host being used for the target library build. Given that several other libraries use similar constraints to get lt_host_flags into LDFLAGS, I guess pollution isn't (or better stated hasn't) been an issue. Approved. Jeff