From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24948 invoked by alias); 18 Jun 2014 13:48:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24919 invoked by uid 89); 18 Jun 2014 13:48:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 13:48:16 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5IDmCUS021464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Jun 2014 09:48:12 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-70.phx2.redhat.com [10.3.113.70]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5IDmBnt031448; Wed, 18 Jun 2014 09:48:11 -0400 Message-ID: <53A1989B.8070003@redhat.com> Date: Wed, 18 Jun 2014 13:48:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Olivier Hainque CC: gcc-patches@gcc.gnu.org Subject: Re: [patch] improve sloc assignment on bind_expr entry/exit code References: <53A0A84F.9020709@redhat.com> <86BF8C70-647C-46AC-852E-3DB1E40A8276@adacore.com> In-Reply-To: <86BF8C70-647C-46AC-852E-3DB1E40A8276@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg01467.txt.bz2 On 06/18/14 01:42, Olivier Hainque wrote: > Hi Jeff, > > On Jun 17, 2014, at 22:42 , Jeff Law wrote: > >>> * tree-core.h (tree_block): Add an "end_locus" field, allowing >>> memorization of the end of block source location. >>> * tree.h (BLOCK_SOURCE_END_LOCATION): New accessor. >>> * gimplify.c (gimplify_bind_expr): Propagate the block start and >>> end source location info we have on the block entry/exit code we >>> generate. >> OK. > > Great, thanks! :-) > >> I assume y'all will add a suitable test to the Ada testsuite and propagate it into the GCC testsuite in due course? > > Yes, I will. At the patch submission time, I was unclear on what dejagnu > device was available to setup a reliable testing protocol for this kind of > issue and I was interested in getting feedback on the patch contents first. > > ISTM that dg-scan-asm for the expected extra .loc's would work, maybe > restricted to some target we know produces .loc directives. > > Sounds appropriate ? Yea, that should be fine. Most folks test x86-64 linux, so that's going to get you the widest net for coverage. jeff