From: Richard Earnshaw <rearnsha@arm.com>
To: Charles Baylis <charles.baylis@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [PATCH 5/9] Optimise __aeabi_ldivmod (stack manipulation)
Date: Wed, 18 Jun 2014 13:53:00 -0000 [thread overview]
Message-ID: <53A199EC.2080005@arm.com> (raw)
In-Reply-To: <1402481995-12749-5-git-send-email-charles.baylis@linaro.org>
On 11/06/14 11:19, Charles Baylis wrote:
> 2014-05-22 Charles Baylis <charles.baylis@linaro.org>
>
> * config/arm/bpabi.S (__aeabi_ldivmod): Optimise stack manipulation.
OK.
R.
> ---
> libgcc/config/arm/bpabi.S | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/libgcc/config/arm/bpabi.S b/libgcc/config/arm/bpabi.S
> index 927e37f..3f9ece5 100644
> --- a/libgcc/config/arm/bpabi.S
> +++ b/libgcc/config/arm/bpabi.S
> @@ -174,18 +174,10 @@ ARM_FUNC_START aeabi_ldivmod
> cfi_start __aeabi_ldivmod, LSYM(Lend_aeabi_ldivmod)
> test_div_by_zero signed
>
> - sub sp, sp, #8
> -#if defined(__thumb2__)
> - mov ip, sp
> - push {ip, lr}
> -#else
> - do_push {sp, lr}
> -#endif
> -98: cfi_push 98b - __aeabi_ldivmod, 0xe, -0xc, 0x10
> + push_for_divide __aeabi_ldivmod
> + /* arguments in (r0:r1), (r2:r3) and *sp */
> bl SYM(__gnu_ldivmod_helper) __PLT__
> - ldr lr, [sp, #4]
> - add sp, sp, #8
> - do_pop {r2, r3}
> + pop_for_divide
> RET
> cfi_end LSYM(Lend_aeabi_ldivmod)
>
>
next prev parent reply other threads:[~2014-06-18 13:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 10:08 [PATCH, ARM, v2] Improve 64 bit division performance Charles Baylis
2014-06-11 9:30 ` Charles Baylis
2014-06-11 9:33 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 1/9] Whitespace Charles Baylis
2014-06-11 10:20 ` [PATCH 3/9] Optimise __aeabi_uldivmod (stack manipulation) Charles Baylis
2014-06-18 13:52 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 7/9] Fix cfi annotations Charles Baylis
2014-06-18 14:04 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 4/9] Optimise __aeabi_uldivmod Charles Baylis
2014-06-18 13:53 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 9/9] Remove __gnu_uldivmod_helper Charles Baylis
2014-06-18 14:09 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 5/9] Optimise __aeabi_ldivmod (stack manipulation) Charles Baylis
2014-06-18 13:53 ` Richard Earnshaw [this message]
2014-06-11 10:20 ` [PATCH 6/9] Optimise __aeabi_ldivmod Charles Baylis
2014-06-18 14:03 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 8/9] Use __udivmoddi4 for v6M aeabi_uldivmod Charles Baylis
2014-06-18 14:04 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 2/9] Add comments Charles Baylis
2014-06-11 12:55 ` Richard Earnshaw
2014-06-11 12:55 ` [PATCH 1/9] Whitespace Richard Earnshaw
2014-06-18 15:55 ` Charles Baylis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A199EC.2080005@arm.com \
--to=rearnsha@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=charles.baylis@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).