From: Richard Earnshaw <rearnsha@arm.com>
To: Charles Baylis <charles.baylis@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [PATCH 7/9] Fix cfi annotations
Date: Wed, 18 Jun 2014 14:04:00 -0000 [thread overview]
Message-ID: <53A19C55.9060902@arm.com> (raw)
In-Reply-To: <1402481995-12749-7-git-send-email-charles.baylis@linaro.org>
On 11/06/14 11:19, Charles Baylis wrote:
> 2014-05-22 Charles Baylis <charles.baylis@linaro.org>
>
> * config/arm/bpabi.S (__aeabi_ldivmod, __aeabi_uldivmod,
> push_for_divide, pop_for_divide): Use .cfi_* directives for DWARF
> annotations. Fix DWARF information.
OK.
> ---
> libgcc/config/arm/bpabi.S | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/libgcc/config/arm/bpabi.S b/libgcc/config/arm/bpabi.S
> index c044167..959ecb1 100644
> --- a/libgcc/config/arm/bpabi.S
> +++ b/libgcc/config/arm/bpabi.S
> @@ -22,6 +22,8 @@
> see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
> <http://www.gnu.org/licenses/>. */
>
> + .cfi_sections .debug_frame
> +
> #ifdef __ARM_EABI__
> /* Some attributes that are common to all routines in this file. */
> /* Tag_ABI_align_needed: This code does not require 8-byte
> @@ -145,7 +147,8 @@ ARM_FUNC_START aeabi_ulcmp
> sub sp, sp, #8
> do_push {sp, lr}
> #endif
> -98: cfi_push 98b - \fname, 0xe, -0xc, 0x10
> + .cfi_adjust_cfa_offset 16
> + .cfi_offset 14, -12
> .endm
>
> /* restore stack */
> @@ -158,6 +161,8 @@ ARM_FUNC_START aeabi_ulcmp
> add sp, sp, #8
> do_pop {r2, r3}
> #endif
> + .cfi_restore 14
> + .cfi_adjust_cfa_offset 0
> .endm
>
> #ifdef L_aeabi_ldivmod
> @@ -171,7 +176,7 @@ ARM_FUNC_START aeabi_ulcmp
> r2:r3 remainder
> */
> ARM_FUNC_START aeabi_ldivmod
> - cfi_start __aeabi_ldivmod, LSYM(Lend_aeabi_ldivmod)
> + .cfi_startproc
> test_div_by_zero signed
>
> push_for_divide __aeabi_ldivmod
> @@ -181,16 +186,19 @@ ARM_FUNC_START aeabi_ldivmod
> blt 2f
> /* arguments in (r0:r1), (r2:r3) and *sp */
> bl SYM(__udivmoddi4) __PLT__
> + .cfi_remember_state
> pop_for_divide
> RET
>
> 1: /* xxh:xxl is negative */
> + .cfi_restore_state
> negs xxl, xxl
> sbc xxh, xxh, xxh, lsl #1 /* Thumb-2 has no RSC, so use X - 2X */
> cmp yyh, #0
> blt 3f
> /* arguments in (r0:r1), (r2:r3) and *sp */
> bl SYM(__udivmoddi4) __PLT__
> + .cfi_remember_state
> pop_for_divide
> negs xxl, xxl
> sbc xxh, xxh, xxh, lsl #1 /* Thumb-2 has no RSC, so use X - 2X */
> @@ -199,16 +207,19 @@ ARM_FUNC_START aeabi_ldivmod
> RET
>
> 2: /* only yyh:yyl is negative */
> + .cfi_restore_state
> negs yyl, yyl
> sbc yyh, yyh, yyh, lsl #1 /* Thumb-2 has no RSC, so use X - 2X */
> /* arguments in (r0:r1), (r2:r3) and *sp */
> bl SYM(__udivmoddi4) __PLT__
> + .cfi_remember_state
> pop_for_divide
> negs xxl, xxl
> sbc xxh, xxh, xxh, lsl #1 /* Thumb-2 has no RSC, so use X - 2X */
> RET
>
> 3: /* both xxh:xxl and yyh:yyl are negative */
> + .cfi_restore_state
> negs yyl, yyl
> sbc yyh, yyh, yyh, lsl #1 /* Thumb-2 has no RSC, so use X - 2X */
> /* arguments in (r0:r1), (r2:r3) and *sp */
> @@ -218,7 +229,7 @@ ARM_FUNC_START aeabi_ldivmod
> sbc yyh, yyh, yyh, lsl #1 /* Thumb-2 has no RSC, so use X - 2X */
> RET
>
> - cfi_end LSYM(Lend_aeabi_ldivmod)
> + .cfi_endproc
>
> #endif /* L_aeabi_ldivmod */
>
> @@ -233,7 +244,7 @@ ARM_FUNC_START aeabi_ldivmod
> r2:r3 remainder
> */
> ARM_FUNC_START aeabi_uldivmod
> - cfi_start __aeabi_uldivmod, LSYM(Lend_aeabi_uldivmod)
> + .cfi_startproc
> test_div_by_zero unsigned
>
> push_for_divide __aeabi_uldivmod
> @@ -241,7 +252,7 @@ ARM_FUNC_START aeabi_uldivmod
> bl SYM(__udivmoddi4) __PLT__
> pop_for_divide
> RET
> - cfi_end LSYM(Lend_aeabi_uldivmod)
> + .cfi_endproc
>
> #endif /* L_aeabi_divmod */
>
>
next prev parent reply other threads:[~2014-06-18 14:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 10:08 [PATCH, ARM, v2] Improve 64 bit division performance Charles Baylis
2014-06-11 9:30 ` Charles Baylis
2014-06-11 9:33 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 1/9] Whitespace Charles Baylis
2014-06-11 10:20 ` [PATCH 7/9] Fix cfi annotations Charles Baylis
2014-06-18 14:04 ` Richard Earnshaw [this message]
2014-06-11 10:20 ` [PATCH 3/9] Optimise __aeabi_uldivmod (stack manipulation) Charles Baylis
2014-06-18 13:52 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 9/9] Remove __gnu_uldivmod_helper Charles Baylis
2014-06-18 14:09 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 4/9] Optimise __aeabi_uldivmod Charles Baylis
2014-06-18 13:53 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 6/9] Optimise __aeabi_ldivmod Charles Baylis
2014-06-18 14:03 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 5/9] Optimise __aeabi_ldivmod (stack manipulation) Charles Baylis
2014-06-18 13:53 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 8/9] Use __udivmoddi4 for v6M aeabi_uldivmod Charles Baylis
2014-06-18 14:04 ` Richard Earnshaw
2014-06-11 10:20 ` [PATCH 2/9] Add comments Charles Baylis
2014-06-11 12:55 ` Richard Earnshaw
2014-06-11 12:55 ` [PATCH 1/9] Whitespace Richard Earnshaw
2014-06-18 15:55 ` Charles Baylis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A19C55.9060902@arm.com \
--to=rearnsha@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=charles.baylis@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).