From: Chung-Lin Tang <cltang@codesourcery.com>
To: <ramrad01@arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <rearnsha@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Julian Brown <julian@codesourcery.com>
Subject: Re: [PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY
Date: Fri, 20 Jun 2014 06:24:00 -0000 [thread overview]
Message-ID: <53A3D39D.3030705@codesourcery.com> (raw)
In-Reply-To: <CAJA7tRYSXYXPcv3kHdqb0vKZycr83NDHUo7um9ho5UJwRZBYFw@mail.gmail.com>
On 2014/6/18 ä¸Šåˆ 06:26, Ramana Radhakrishnan wrote:
> On Sun, Jun 8, 2014 at 12:27 PM, Chung-Lin Tang <cltang@codesourcery.com> wrote:
>> > Hi Richard, Ramana,
>> >
>> > Attached is a small fix for resolving a g++.old-deja/g++.jason/thunk2.C
>> > regression we found under a TARGET_THUMB1_ONLY multilib (-mthumb
>> > -march=armv6-m to be exact). Basically under those conditions, the thunk
>> > is in Thumb mode, so the subtraction should be 4 rather than 8.
> Yep, this is OK with a minor change to the comment to make it more explicit.
>
>> >+ /* Output ".word .LTHUNKn-[37]-.LTHUNKPCn". */
> s/37/3,7/
>
>
> Ok with that change and if no regressions.
>
> OK for release branches unless the RM's object in 24 hours.
Re-tested on a recent trunk, verified g++.jason/thunk2.C resolved with
patch and no regressions. Committed on trunk and backported to 4.8, 4.9
branches.
Thanks,
Chung-Lin
prev parent reply other threads:[~2014-06-20 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 11:27 Chung-Lin Tang
2014-06-17 22:26 ` Ramana Radhakrishnan
2014-06-20 6:24 ` Chung-Lin Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A3D39D.3030705@codesourcery.com \
--to=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=julian@codesourcery.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=ramrad01@arm.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).