From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4129 invoked by alias); 22 Jun 2014 23:53:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4117 invoked by uid 89); 22 Jun 2014 23:53:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Jun 2014 23:53:41 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WyrZn-0005Fa-N2 from Sandra_Loosemore@mentor.com ; Sun, 22 Jun 2014 16:53:35 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 22 Jun 2014 16:53:35 -0700 Received: from [IPv6:::1] (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Sun, 22 Jun 2014 16:53:35 -0700 Message-ID: <53A76C75.9090907@codesourcery.com> Date: Sun, 22 Jun 2014 23:53:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jeff Law , GCC Patches , Subject: Re: [patch, mips] delete bit-rotten ADJUST_REG_ALLOC_ORDER definition References: <53727C74.2070502@codesourcery.com> <5373AF23.7000206@redhat.com> <878uq4ci0m.fsf@talisman.default> In-Reply-To: <878uq4ci0m.fsf@talisman.default> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg01698.txt.bz2 On 05/14/2014 12:49 PM, Richard Sandiford wrote: > Jeff Law writes: >> On 05/13/14 14:11, Sandra Loosemore wrote: >>> >>> 2014-05-13 Catherine Moore >>> Sandra Loosemore >>> >>> gcc/ >>> * config/mips/mips.c (mips_order_regs_for_local_alloc): Delete. >>> * config/mips/mips.h (ADJUST_REG_ALLOC_ORDER): Delete. >>> * config/mips/mips-protos.h (mips_order_regs_for_local_alloc): Delete. >> OK for the trunk. > > Would it be OK to hold off until after the switch to LRA? That patch > has been written and the MIPS parts approved, but we're waiting for > some legal things to be sorted out and for a fixed version of the LRA > EXTRA_MEMORY_CONSTRAINT patch. I just think it'd be better to tune this > sort of thing once that's done, rather than tune it against reload. Richard, is it OK to commit this patch now that LRA is in, or do you want to experiment some more with tuning first? I think we're all in agreement that this is broken old code that should be removed regardless of whether we do other things to tune REG_ALLOC_ORDER. -Sandra