From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30738 invoked by alias); 25 Jun 2014 18:28:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30723 invoked by uid 89); 25 Jun 2014 18:28:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 25 Jun 2014 18:28:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5PISHum030537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2014 14:28:18 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-44.phx2.redhat.com [10.3.113.44]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5PISGaD021158; Wed, 25 Jun 2014 14:28:16 -0400 Message-ID: <53AB14C0.1010606@redhat.com> Date: Wed, 25 Jun 2014 18:28:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix parts of PR61607 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg02046.txt.bz2 On 06/25/14 08:05, Richard Biener wrote: > > This removes restrictions in DOM cprop_operand that inhibit > some optimizations. The volatile pointer thing is really realy > old and no longer necessary while the loop-depth consideration > is only valid for loop-closed PHI nodes (but we're not in > loop-closed SSA in DOM) - the coalescing is handled in out-of-SSA > phase by inserting copies appropriately. > > Bootstrapped on x86_64-unknown-linux-gnu, ok? > > Thanks, > Richard. > > 2014-06-25 Richard Biener > > PR tree-optimization/61607 > * tree-ssa-dom.c (cprop_operand): Remove restriction on > propagating volatile pointers and on loop depth. The first hunk is OK. I thought we had tests for the do not copy propagate out of a loop nest in the suite. Did you check that tests in BZ 19038 still generate good code after this change? If we still generate good code for those tests, then this hunk is fine too. Jeff