From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-371389-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 3280 invoked by alias); 28 Jun 2014 19:32:17 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 3267 invoked by uid 89); 28 Jun 2014 19:32:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: fencepost.gnu.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 28 Jun 2014 19:32:15 +0000
Received: from adsl-76-254-28-114.dsl.pltn13.sbcglobal.net ([76.254.28.114]:57523 helo=[172.16.16.2])	by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)	(Exim 4.71)	(envelope-from <bkorb@gnu.org>)	id 1X0yM7-0001Tk-NN; Sat, 28 Jun 2014 15:32:12 -0400
Message-ID: <53AF1839.9040502@gnu.org>
Date: Sat, 28 Jun 2014 19:32:00 -0000
From: Bruce Korb <bkorb@gnu.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9
MIME-Version: 1.0
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
CC: gcc-patches@gcc.gnu.org, "Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [fixincludes] Fix <iso/math_c99.h> signbit on Solaris
References: <yddionouizd.fsf@lokon.CeBiTec.Uni-Bielefeld.DE>
In-Reply-To: <yddionouizd.fsf@lokon.CeBiTec.Uni-Bielefeld.DE>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-06/txt/msg02309.txt.bz2

On 06/26/14 02:18, Rainer Orth wrote:
> Ok for mainline?

Could you please reformat the c_fix_arg's and test-text to be "here strings" a la:

     c_fix_arg = <<- _EOS_
	#undef	signbit
	#define	signbit(x)	(sizeof(x) == sizeof(float) \
	\			   ? __builtin_signbitf(x) \
	\			   : sizeof(x) == sizeof(long double) \
	\			     ? __builtin_signbitl(x) \
	\			     : __builtin_signbit(x))";
	_EOS_;

I changed the "here string" thingy to eat that tab-backslash
and leave the rest of the tabs a few years ago.
That is considerably more readable than:

     c_fix_arg = "#undef\tsignbit\n"
		"#define\tsignbit(x)\t(sizeof(x) == sizeof(float) \\\n"
                 "\t\t\t   ? __builtin_signbitf(x) \\\n"
                 "\t\t\t   : sizeof(x) == sizeof(long double) \\\n"
                 "\t\t\t     ? __builtin_signbitl(x) \\\n"
                 "\t\t\t     : __builtin_signbit(x))";

and the other two are worse.  Thank you!