From: Jason Merrill <jason@redhat.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>,
"Gcc Patch List" <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <richard.guenther@gmail.com>,
Jakub Jelinek <jakub@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Siddhesh Poyarekar <siddhesh@redhat.com>,
"Carlos O'Donell" <carlos@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)
Date: Wed, 09 Jul 2014 21:28:00 -0000 [thread overview]
Message-ID: <53BDB402.20309@redhat.com> (raw)
In-Reply-To: <CAESRpQDeicuneH9VGgCEhUNz3Kfn3EAJa+JO64iqLoHH9xgbpA@mail.gmail.com>
On 07/09/2014 10:40 AM, Manuel López-Ibáñez wrote:
>> All of these warnings (-Wsizeof-pointer-memaccess, -Wsizeof-array-argument
>> and -Wmemset-transposed-args) are implemented in a hackish way, because we
>> fold everything too early. Perhaps for such analysis we want a FOLDED_EXPR
>> which would have arguments what it has been folded to and the original tree,
>> for the purposes of code generation the first argument would be used and
>> the second one only for the analysis. We don't have that many spots where
>> we need the original trees to be analyzed yet for it to be worth it though
>> IMHO.
>
> But if we keep adding hacks around it, there will never be progress
> and the person(s) who take the challenge of properly fixing this will
> not only have to deal with the task itself but also with all the ugly
> and obscure hacks added year after year.
I'm planning to address this soon, hopefully this stage 1.
Jason
next prev parent reply other threads:[~2014-07-09 21:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 14:40 Manuel López-Ibáñez
2014-07-09 21:28 ` Jason Merrill [this message]
2014-07-10 12:52 ` [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2) Jakub Jelinek
2014-07-10 17:57 ` Jason Merrill
2014-07-10 23:29 ` Gerald Pfeifer
2014-07-11 20:19 ` Jakub Jelinek
2015-04-12 19:30 ` Gerald Pfeifer
-- strict thread matches above, loose matches on Subject: below --
2014-07-08 12:50 [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294) Jakub Jelinek
2014-07-08 19:25 ` Jason Merrill
2014-07-08 19:38 ` Carlos O'Donell
2014-07-08 20:32 ` Jakub Jelinek
2014-07-08 22:33 ` Jason Merrill
2014-07-09 10:26 ` Richard Biener
2014-07-09 10:33 ` Jakub Jelinek
2014-07-09 10:51 ` Richard Biener
2014-07-09 11:09 ` Jakub Jelinek
2014-07-08 19:34 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDB402.20309@redhat.com \
--to=jason@redhat.com \
--cc=carlos@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lopezibanez@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).