From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21305 invoked by alias); 10 Jul 2014 22:21:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20960 invoked by uid 89); 10 Jul 2014 22:21:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 10 Jul 2014 22:21:00 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s6AMKvvu027590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Jul 2014 22:20:58 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6AMKuKA002502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Jul 2014 22:20:57 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6AMKuEl002493; Thu, 10 Jul 2014 22:20:56 GMT Received: from [192.168.1.4] (/79.12.219.253) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 10 Jul 2014 15:20:56 -0700 Message-ID: <53BF10D6.8060803@oracle.com> Date: Thu, 10 Jul 2014 22:21:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Jason Merrill , "gcc-patches@gcc.gnu.org" Subject: Re: [C++ Patch/RFC] Back to PR 53159 References: <53BEE7D6.4040808@oracle.com> <53BEFDBA.1060508@redhat.com> In-Reply-To: <53BEFDBA.1060508@redhat.com> Content-Type: multipart/mixed; boundary="------------040007010907030703030807" X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00741.txt.bz2 This is a multi-part message in MIME format. --------------040007010907030703030807 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 865 Hi, On 07/10/2014 10:55 PM, Jason Merrill wrote: > Hmm, why aren't we already getting the error from > >> if (convs->check_narrowing) >> check_narrowing (totype, expr); > > in convert_like_real? Is it that we need to copy LOOKUP_NO_NARROWING > into convflags in build_user_type_conversion_1? Ah, ah, thanks. Frankly I noticed that flag but somehow decided to not focus on it :( Anyway, certainly build_user_type_conversion_1 can be tweaked as you are suggesting, the only missing bit is that it doesn't get LOOKUP_NO_NARROWING in the flags, and cannot figure it out from expr because it's a TARGET_EXPR at that point. Thus it seems to me we have to pass it down from, say, check_initializer when init is still a CONSTRUCTOR and its BRACE_ENCLOSED_INITIALIZER_P (init) is set? I'm going to test the below... makes sense? Paolo. ////////////////// --------------040007010907030703030807 Content-Type: text/plain; charset=UTF-8; name="p" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="p" Content-length: 1257 SW5kZXg6IGNhbGwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjYWxs LmMJKHJldmlzaW9uIDIxMjQzMSkKKysrIGNhbGwuYwkod29ya2luZyBjb3B5 KQpAQCAtMzU4Niw3ICszNTg2LDggQEAgYnVpbGRfdXNlcl90eXBlX2NvbnZl cnNpb25fMSAodHJlZSB0b3R5cGUsIHRyZWUgZXgKIAogICAvKiBJdCdzIE9L IHRvIGJpbmQgYSB0ZW1wb3JhcnkgZm9yIGNvbnZlcnRpbmcgY29uc3RydWN0 b3IgYXJndW1lbnRzLCBidXQKICAgICAgbm90IGluIGNvbnZlcnRpbmcgdGhl IHJldHVybiB2YWx1ZSBvZiBhIGNvbnZlcnNpb24gb3BlcmF0b3IuICAqLwot ICBjb252ZmxhZ3MgPSAoKGZsYWdzICYgTE9PS1VQX05PX1RFTVBfQklORCkg fCBMT09LVVBfTk9fQ09OVkVSU0lPTik7CisgIGNvbnZmbGFncyA9ICgoZmxh Z3MgJiBMT09LVVBfTk9fVEVNUF9CSU5EKSB8IExPT0tVUF9OT19DT05WRVJT SU9OCisJICAgICAgIHwgKGZsYWdzICYgTE9PS1VQX05PX05BUlJPV0lORykp OwogICBmbGFncyAmPSB+TE9PS1VQX05PX1RFTVBfQklORDsKIAogICBpZiAo Y3RvcnMpCkluZGV4OiBkZWNsLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gZGVjbC5jCShyZXZpc2lvbiAyMTI0MzEpCisrKyBkZWNsLmMJKHdvcmtp bmcgY29weSkKQEAgLTU3MDcsNiArNTcwNyw3IEBAIGNoZWNrX2luaXRpYWxp emVyICh0cmVlIGRlY2wsIHRyZWUgaW5pdCwgaW50IGZsYWdzCiAJICAgICAg cmV0dXJuIE5VTExfVFJFRTsKIAkgICAgfQogCX0KKyAgICAgIGZsYWdzIHw9 IExPT0tVUF9OT19OQVJST1dJTkc7CiAgICAgfQogCiAgIGlmIChUUkVFX0NP REUgKGRlY2wpID09IENPTlNUX0RFQ0wpCg== --------------040007010907030703030807--