From: Tobias Grosser <tobias@grosser.es>
To: Roman Gareev <gareevroman@gmail.com>
Cc: Mircea Namolaru <mircea.namolaru@inria.fr>, gcc-patches@gcc.gnu.org
Subject: Re: [GSoC] generation of Gimple loops with empty bodies
Date: Fri, 11 Jul 2014 11:15:00 -0000 [thread overview]
Message-ID: <53BFC753.2090702@grosser.es> (raw)
In-Reply-To: <CABGF_gcGmSKAudosjXr3EAXgUyBt7kKEdaSnLkSRCQ5S7tCYYg@mail.gmail.com>
On 11/07/2014 13:11, Roman Gareev wrote:
>> The struct now contains only a single element such that there seems to be no
>> need for it anymore. Should we remove it? (We could still use a typedef if
>> you believe the datatype is too long).
>
> I don't mind removing it. However I think that we should choose the
> way of transferring of sese region, which is used for translation of
> an isl_ast_node_user to Gimple code. Should we transfer it separately
> or restore ivs_params later? What do you think?
Sorry, I currently don't see why sese region is needed later. In case it
is, we may keep it, but this would require to pull more code in the
review. I personally would just remove it to finish this review.
Feel free to commit after applying this change.
Cheers,
Tobias
next prev parent reply other threads:[~2014-07-11 11:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 7:06 Roman Gareev
2014-07-07 11:11 ` Tobias Grosser
2014-07-08 12:47 ` Roman Gareev
2014-07-08 13:18 ` Tobias Grosser
2014-07-11 9:01 ` Roman Gareev
2014-07-11 9:18 ` Tobias Grosser
2014-07-11 11:11 ` Roman Gareev
2014-07-11 11:15 ` Tobias Grosser [this message]
2014-07-11 13:42 ` Roman Gareev
2014-07-11 13:44 ` Tobias Grosser
2014-07-12 10:13 Dominique Dhumieres
2014-07-13 10:34 ` Roman Gareev
2014-07-13 12:35 ` Dominique Dhumieres
2014-07-13 13:14 ` Dominique Dhumieres
2014-07-13 14:49 ` Tobias Grosser
2014-07-15 15:19 ` Roman Gareev
[not found] ` <53C54C7E.5050102@grosser.es>
[not found] ` <CAFiYyc1LoP1VDX57CmV_mdULBAObGzvmwtJ1zQxOA78HDbHSKA@mail.gmail.com>
[not found] ` <53C7DB6F.1050707@grosser.es>
2014-07-18 10:52 ` Roman Gareev
2014-07-18 11:28 ` Tobias Grosser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFC753.2090702@grosser.es \
--to=tobias@grosser.es \
--cc=gareevroman@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mircea.namolaru@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).