From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31493 invoked by alias); 12 Jul 2014 22:40:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31478 invoked by uid 89); 12 Jul 2014 22:40:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Jul 2014 22:40:30 +0000 Received: by mail-pa0-f49.google.com with SMTP id lj1so3305940pab.8 for ; Sat, 12 Jul 2014 15:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=9Q5zxVALNcw8OBRt4PURNGQNP/S6C0LAlC4ok4b79Tg=; b=abEwSSrQu4tdZpwzIG92eQ5uxJo2J++KcN8M/mjpe5avuoLUnnUwGM8S6VUAaNYTCT t34ThFmAi0eGKGVXOQF2oFkNQuZccoG9rWfQIb8Hl7TVrZGceD6ns86Upp3/Alb59oU1 GKzjj4YAhGqlbJVe4aJAeuTNDy4tfb10J/grStDSmjQjIBSbWlDZCI2YCJLPoxr03l1d jkqgurIqofUxeA4OaNY3CLhFd4MvVLZqraq5ttHJDKxzV7/g4LEZCkF/vafWhUu3F9SQ aQlJppMbL78u8oTXpMP5QNpTbZSBj0b+IK95DwVj6LgpU6fz87WElQ2yicBVZbVr5vTq QTCw== X-Gm-Message-State: ALoCoQl810sGQUjbZSva7tXX0d3iEnXcw1HUgPm01LrsxqULOYEda/2JljATPyvpxG+ba6cg9fVx X-Received: by 10.70.90.207 with SMTP id by15mr7359802pdb.31.1405204827525; Sat, 12 Jul 2014 15:40:27 -0700 (PDT) Received: from [10.1.1.4] (58-6-183-210.dyn.iinet.net.au. [58.6.183.210]) by mx.google.com with ESMTPSA id cr3sm8299696pdb.43.2014.07.12.15.40.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 12 Jul 2014 15:40:26 -0700 (PDT) Message-ID: <53C1B956.1050407@linaro.org> Date: Sat, 12 Jul 2014 22:40:00 -0000 From: Kugan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Ramana Radhakrishnan , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Jay Foad , Uros Bizjak Subject: Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------060609080009000303020305" X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00888.txt.bz2 This is a multi-part message in MIME format. --------------060609080009000303020305 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 908 > > - if (!TARGET_VFP) > - return; > + if (!TARGET_VFP || TARGET_THUMB1) > + return default_atomic_assign_expand_fenv (hold, clear, update); > > You don't need to call default function here. It is empty, the > documentation says: > > "The default implementation leaves all three expressions as @code{NULL_TREE}." > > Also, the function is declared as void, so returning something looks > strange to me. Thanks for the comment. Here is a patch to change this. There was also a comment from Jay with respect to a cut and paste error that might confuse the readers. I am fixing that as well. regression tested on qemu for arm-none-linux-gnueabi with no new regressions. Please let me know if this is OK? Thanks, Kugan gcc/ 2014-057-12 Kugan Vivekanandarajah * config/arm/arm.c (bdesc_2arg): Fix typo. (arm_atomic_assign_expand_fenv): Remove The default implementation. --------------060609080009000303020305 Content-Type: text/plain; charset=UTF-8; name="fenv.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fenv.txt" Content-length: 1143 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYXJtL2FybS5jIGIvZ2NjL2NvbmZp Zy9hcm0vYXJtLmMKaW5kZXggNzhjYWU3My4uYjg0NTk0ZCAxMDA2NDQKLS0t IGEvZ2NjL2NvbmZpZy9hcm0vYXJtLmMKKysrIGIvZ2NjL2NvbmZpZy9hcm0v YXJtLmMKQEAgLTI0MzY2LDggKzI0MzY2LDggQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCBidWlsdGluX2Rlc2NyaXB0aW9uIGJkZXNjXzJhcmdbXSA9CiAgIHsw LCBDT0RFX0ZPUl8jI0wsICJfX2J1aWx0aW5fYXJtXyIjTCwgQVJNX0JVSUxU SU5fIyNVLCBcCiAgICBVTktOT1dOLCAwfSwKIAotICBGUF9CVUlMVElOIChz ZXRfZnBzY3IsIEdFVF9GUFNDUikKLSAgRlBfQlVJTFRJTiAoZ2V0X2Zwc2Ny LCBTRVRfRlBTQ1IpCisgIEZQX0JVSUxUSU4gKGdldF9mcHNjciwgR0VUX0ZQ U0NSKQorICBGUF9CVUlMVElOIChzZXRfZnBzY3IsIFNFVF9GUFNDUikKICN1 bmRlZiBGUF9CVUlMVElOCiAKICNkZWZpbmUgQ1JDMzJfQlVJTFRJTihMLCBV KSBcCkBAIC0zMTU4Miw3ICszMTU4Miw3IEBAIGFybV9hdG9taWNfYXNzaWdu X2V4cGFuZF9mZW52ICh0cmVlICpob2xkLCB0cmVlICpjbGVhciwgdHJlZSAq dXBkYXRlKQogICB0cmVlIHVwZGF0ZV9jYWxsLCBhdG9taWNfZmVyYWlzZWV4 Y2VwdCwgaG9sZF9mbmNsZXg7CiAKICAgaWYgKCFUQVJHRVRfVkZQIHx8ICFU QVJHRVRfSEFSRF9GTE9BVCkKLSAgICByZXR1cm4gZGVmYXVsdF9hdG9taWNf YXNzaWduX2V4cGFuZF9mZW52IChob2xkLCBjbGVhciwgdXBkYXRlKTsKKyAg ICByZXR1cm47CiAKICAgLyogR2VuZXJhdGUgdGhlIGVxdWl2YWxlbnQgb2Yg OgogICAgICAgIHVuc2lnbmVkIGludCBmZW52X3ZhcjsK --------------060609080009000303020305--