public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: Uros Bizjak <ubizjak@gmail.com>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, i386]: Optimize ix86_atomic_assign_expand_fenv a bit
Date: Mon, 14 Jul 2014 08:05:00 -0000	[thread overview]
Message-ID: <53C38F48.6000200@arm.com> (raw)
In-Reply-To: <CAFULd4aEXGU+3ZRTf9Hwh5uu6vX071MZnAw_Q9A1zAwiYL-R+g@mail.gmail.com>


On 12/07/14 10:07, Uros Bizjak wrote:
> Hello!
>
> Attached patch optimizes ix86_atomic_assign_expand_fenv by using
> register form of "fnstsw %ax" instead of "fnstsw <mem>". This way a
> memory RW cycle is removed for a temporary.

Hi Uros,

The patch you attached seems to be the hook implementation for alpha...

Kyrill

> 2014-07-12  Uros Bizjak  <ubizjak@gmail.com>
>
>      * config/i386/i386-builtin-types.def: Add USHORT_FTYPE_VOID.
>      Remove VOID_FTYPE_PUSHORT.
>      * config/i386/i386.c (bdesc_special_args) <__builtin_ia32_fnstsw>:
>      Change code to USHORT_FTYPE_VOID.
>      (ix86_expand_special_args_builtin): Handle USHORT_FTYPE_VOID.
>      (ix86_expand_builtin): Remove IX86_BUILTIN_FNSTSW handling.
>      (ix86_atomic_assign_expand_fenv): Update for
>      __builtin_ia32_fnstsw changes.
>      * config/i386/i386.md (x86_fnstsw_1): Set length unconditionally to 2.
>      (fnstsw): Change operand 0 to nonimmediate operand.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32} and
> committed to mainline SVN.
>
> Uros.


  reply	other threads:[~2014-07-14  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12  9:07 Uros Bizjak
2014-07-14  8:05 ` Kyrill Tkachov [this message]
2014-07-14  8:11   ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C38F48.6000200@arm.com \
    --to=kyrylo.tkachov@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).