From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19978 invoked by alias); 14 Jul 2014 08:18:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19964 invoked by uid 89); 14 Jul 2014 08:18:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 14 Jul 2014 08:18:14 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s6E8IB3E014307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Jul 2014 08:18:12 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6E8IA1V017322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Jul 2014 08:18:11 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s6E8I8NB018504; Mon, 14 Jul 2014 08:18:09 GMT Received: from [192.168.1.4] (/79.21.175.104) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 14 Jul 2014 01:18:08 -0700 Message-ID: <53C39149.8000001@oracle.com> Date: Mon, 14 Jul 2014 08:18:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Andreas Schwab , Ulrich Drepper CC: Ed Smith-Rowland <3dw4rd@verizon.net>, gcc-patches Subject: Re: [PATCH] libstdc++: add uniform on sphere distribution References: <53C28FBB.9080708@verizon.net> <53C2A91D.1070808@oracle.com> <53C2AED6.4040402@oracle.com> <53C2B301.2030205@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00949.txt.bz2 Hi, On 07/14/2014 09:58 AM, Andreas Schwab wrote: > FAIL: ext/random/arcsine_distribution/cons/default.cc (test for excess errors) > Excess errors: > /daten/aranym/gcc/gcc-20140714/libstdc++-v3/include/ext/random.tcc:1587:22: error: '_M_n' was not declared in this scope > /daten/aranym/gcc/gcc-20140714/libstdc++-v3/include/ext/random.tcc:1598:22: error: '_M_n' was not declared in this scope Ulrich please fix those _M_n to __x._M_n and remove the obsolete comments. We could also add the usual minimal set of tests exercising serialization. Thanks. Paolo.