[patch, avr] Device macro correction for rev devices

[patch, avr] Device macro correction for rev devices

[S, Pitchumani]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Attached patch changes the device name macro of two rev devices, from REV
to rev in the name.

Device name macro:
__AVR_ATmega16HVBREVB__
__AVR_ATmega32HVBREVB__

Change to:
__AVR_ATmega16HVBrevB__
__AVR_ATmega32HVBrevB__

'rev' in small letters emphasizes the revision of the device.

If OK, could someone commit please?

Regards,
Pitchumani

gcc/ChangeLog

2014-07-14  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>

    * config/avr/avr-mcus.def (atmega16hvbrevb): Change device name macro
    to __AVR_ATmega16HVBrevB__.
    (atmega32hvbrevb): Change device name macro to __AVR_ATmega32HVBrevB__.


[-- Attachment #2: avr-gcc-device-macro-change.patch --]
[-- Type: application/octet-stream, Size: 2226 bytes --]

diff --git a/gcc/config/avr/avr-mcus.def b/gcc/config/avr/avr-mcus.def
index 0a6d7c8..358f464 100644
--- a/gcc/config/avr/avr-mcus.def
+++ b/gcc/config/avr/avr-mcus.def
@@ -179,7 +179,7 @@ AVR_MCU ("atmega169a",           ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega169A__",
 AVR_MCU ("atmega169p",           ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega169P__",        0x0100, 0x0, 1, "m169p")
 AVR_MCU ("atmega169pa",          ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega169PA__",       0x0100, 0x0, 1, "m169pa")
 AVR_MCU ("atmega16hvb",          ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega16HVB__",       0x0100, 0x0, 1, "m16hvb")
-AVR_MCU ("atmega16hvbrevb",      ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega16HVBREVB__",   0x0100, 0x0, 1, "m16hvbrevb")
+AVR_MCU ("atmega16hvbrevb",      ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega16HVBrevB__",   0x0100, 0x0, 1, "m16hvbrevb")
 AVR_MCU ("atmega16m1",           ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega16M1__",        0x0100, 0x0, 1, "m16m1")
 AVR_MCU ("atmega16u4",           ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega16U4__",        0x0100, 0x0, 1, "m16u4")
 AVR_MCU ("atmega26hvg",          ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega26HVG__",       0x0100, 0x0, 1, "m26hvg")
@@ -238,7 +238,7 @@ AVR_MCU ("atmega64m1",           ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega64M1__",
 AVR_MCU ("atmega64hve",          ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega64HVE__",       0x0100, 0x0, 1, "m64hve")
 AVR_MCU ("atmega64rfa2",         ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega64RFA2__",      0x0200, 0x0, 1, "m64rfa2")
 AVR_MCU ("atmega64rfr2",         ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega64RFR2__",      0x0200, 0x0, 1, "m64rfr2")
-AVR_MCU ("atmega32hvbrevb",      ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega32HVBREVB__",   0x0100, 0x0, 1, "m32hvbrevb")
+AVR_MCU ("atmega32hvbrevb",      ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega32HVBrevB__",   0x0100, 0x0, 1, "m32hvbrevb")
 AVR_MCU ("atmega48hvf",          ARCH_AVR5, AVR_ISA_NONE, "__AVR_ATmega48HVF__",       0x0100, 0x0, 1, "m48hvf")
 AVR_MCU ("at90can32",            ARCH_AVR5, AVR_ISA_NONE, "__AVR_AT90CAN32__",         0x0100, 0x0, 1, "can32")
 AVR_MCU ("at90can64",            ARCH_AVR5, AVR_ISA_NONE, "__AVR_AT90CAN64__",         0x0100, 0x0, 1, "can64")

Re: [patch, avr] Device macro correction for rev devices

[Georg-Johann Lay]

S, Pitchumani schrieb:
> Attached patch changes the device name macro of two rev devices, from REV
> to rev in the name.
> 
> Device name macro:
> __AVR_ATmega16HVBREVB__
> __AVR_ATmega32HVBREVB__
> 
> Change to:
> __AVR_ATmega16HVBrevB__
> __AVR_ATmega32HVBrevB__
> 
> 'rev' in small letters emphasizes the revision of the device.

This is *NOT* OK.

The built-in macros for these devices have been uppercase in avr-gcc and 
AVR-Libc aver since, and they have always be compatible.

Just because one vendor (Atmel) lost track of their patches is no reason 
to introduce changes that render tools incompatible with existing code 
or with bit older versions of AVR-Libc or GCC.

BTW; the same change has been rejected for AVR-Libc for the same reason:

http://savannah.nongnu.org/bugs/?42696

Johann



> 
> Regards,
> Pitchumani
> 
> gcc/ChangeLog
> 
> 2014-07-14  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>
> 
>     * config/avr/avr-mcus.def (atmega16hvbrevb): Change device name macro
>     to __AVR_ATmega16HVBrevB__.
>     (atmega32hvbrevb): Change device name macro to __AVR_ATmega32HVBrevB__.
>