From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-372700-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 24571 invoked by alias); 16 Jul 2014 15:03:41 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 24546 invoked by uid 89); 16 Jul 2014 15:03:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: limegreensocks.com
Received: from limegreensocks.com (HELO limegreensocks.com) (207.118.20.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Wed, 16 Jul 2014 15:03:37 +0000
Received: from [192.168.30.83] ([216.105.224.27]) by limegreensocks.com via TCP with ESMTPSA; Wed, 16 Jul 2014 08:03:35 -0700
Message-ID: <53C69430.3030506@LimeGreenSocks.com>
Date: Wed, 16 Jul 2014 15:22:00 -0000
From: David Wohlferd <dw@LimeGreenSocks.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Uros Bizjak <ubizjak@gmail.com>
CC: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,  "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [Patch] PR 61662
References: <CAFULd4Yo5Byq_jWmhKA0OqKaWRg0iixE5PEnEBumYFMkuy=Beg@mail.gmail.com>
In-Reply-To: <CAFULd4Yo5Byq_jWmhKA0OqKaWRg0iixE5PEnEBumYFMkuy=Beg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg01155.txt.bz2


On 7/15/2014 11:10 AM, Uros Bizjak wrote:
> Hello!
>
>> The detailed description and examples can be found in pr61662, but in short: using "#ifdef
>> __x86_64__" to determine the size of a 'long' does not reliably yield the correct result. This
>> causes _lrotl and _lrotr to return incorrect results on LLP64 systems (like Windows).
>>
>> ChangeLog:
>> 2014-07-09  David Wohlferd <dw@LimeGreenSocks.com>
>>
>>          PR target/61662
>>          * config/i386/ia32intrin.h: Use __LP64__ to determine size of long
> This is OK for mainline and 4.9 backport.

Thank you for reviewing and approving this.  However while I have a 
release on file with FSF, I don't have SVN write permissions, so I 
cannot check this in.

dw