On 06/30/2014 08:54 PM, Jeff Law wrote: > On 06/30/14 05:49, Martin Liška wrote: >> >> On 06/17/2014 10:00 PM, Jeff Law wrote: >>> On 06/13/14 04:26, mliska wrote: >>>> Hi, >>>> this small patch prepares remaining needed infrastructure for >>>> the new pass. >>>> >>>> Changelog: >>>> >>>> 2014-06-13 Martin Liska >>>> Honza Hubicka >>>> >>>> * ipa-utils.h (polymorphic_type_binfo_p): Function marked external >>>> instead of static. >>>> * ipa-devirt.c (polymorphic_type_binfo_p): Likewise. >>>> * ipa-prop.h (count_formal_params): Likewise. >>>> * ipa-prop.c (count_formal_params): Likewise. >>>> * ipa-utils.c (ipa_merge_profiles): Be more tolerant if we merge >>>> profiles for semantically equivalent functions. >>>> * passes.c (do_per_function): If we load body of a function >>>> during WPA, >>>> this condition should behave same. >>>> * varpool.c (ctor_for_folding): More tolerant assert for variable >>>> aliases created during WPA. >>> Presumably we don't have any useful way to merge the cases where we >>> have provides for SRC & DST in ipa_merge_profiles or even to guess >>> which is more useful when presented with both? Does it make sense to >>> log this into a debugging file when we drop one? >> Hello, >> this merge function was written by Honza, what do you think Honza >> about this note? >> >>> I think this patch is fine. If adding logging makes sense, then feel >>> free to do so and consider that trivial change pre-approved. >> I made a small change to this patch, where I moved >> 'gsi_next_nonvirtual_phi' from the pass to gimple-iterator.h. >> >> Ready for trunk with this change? > Yes. I think with the exception of patch #3/5 everything looks good. I'll try to get another pass over #3 this week. What I looked at last week was pretty good; I'm pretty confident this will be wrapped up shortly. > > If #1/#2 make sense to install independent of #3, go ahead. #4/#5 are obviously dependent on #3. > > Jeff Hello, thank you for approval, this final version removes few hunks that are not needed any more. Changes are just cosmetic and I will commit the patch at the beginning of next week. Thanks, Martin