From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2147 invoked by alias); 20 Jul 2014 17:06:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2093 invoked by uid 89); 20 Jul 2014 17:06:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC,TVD_RCVD_IP autolearn=no version=3.3.2 X-HELO: batou.ecranbleu.org Received: from 195-154-220-89.rev.poneytelecom.eu (HELO batou.ecranbleu.org) (195.154.220.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Jul 2014 17:06:21 +0000 Received: by batou.ecranbleu.org (Postfix, from userid 999) id 054C21224A6; Sun, 20 Jul 2014 19:06:21 +0200 (CEST) Received: from [192.168.12.5] (unknown [192.168.12.5]) (Authenticated sender: sylvestredeb@ledru.info) by batou.ecranbleu.org (Postfix) with ESMTPSA id 6CD8C1202F8; Sun, 20 Jul 2014 19:06:20 +0200 (CEST) Message-ID: <53CBF70A.1020602@debian.org> Date: Sun, 20 Jul 2014 19:20:00 -0000 From: Sylvestre Ledru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gcc-patches@gcc.gnu.org, Jason Merrill Subject: Re: [Patch] PR55189 enable -Wreturn-type by default References: <538F7856.1090104@debian.org> <53903961.9030501@debian.org> <53A07226.4040803@debian.org> <53A07CCC.2030004@debian.org> <53BAD646.7020102@debian.org> In-Reply-To: <53BAD646.7020102@debian.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg01370.txt.bz2 Joseph, ping :) (I know you were in holidays) S On 07/07/2014 19:17, Sylvestre Ledru wrote: > Hello, > > On 17/06/2014 19:41, Joseph S. Myers wrote: >> On Tue, 17 Jun 2014, Sylvestre Ledru wrote: >> >>> OK. I will do that. >>> We should test the following: >>> * default => run just -Wreturn-type >>> * -Wreturn-type => Run both >>> * -Wreturn-type + -Wmissing-return => Run both >>> * -Wno-return-type + -Wmissing-return => Run just the second one >>> * -Wno-return-type + -Wno-missing-return => Run none >>> Do you see any other? >> That looks like the right things to test, if there are no changes for >> anything other than those options. > Here it is: > https://github.com/sylvestre/gcc/commit/db8aaac91aa09fd1ec1cc8974586aec45a221e71 > > Is that what you expected? > >>> Besides that, are you OK with my changes? (with the tests updated) >> The tests are key to reviewing whether the code changes actually do the >> right thing. > Right. > > Thanks again for your help and comments, it is really appreciated, > Sylvestre >