From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30188 invoked by alias); 25 Jul 2014 20:05:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30159 invoked by uid 89); 25 Jul 2014 20:04:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Jul 2014 20:04:58 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6PK4uAU010044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Jul 2014 16:04:56 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-30.phx2.redhat.com [10.3.113.30]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6PK4tTl027196; Fri, 25 Jul 2014 16:04:55 -0400 Message-ID: <53D2B867.1080706@redhat.com> Date: Fri, 25 Jul 2014 20:41:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: Re: RFA: Add a common tls_referenced_p function References: <87k372n4m5.fsf@talisman.default> In-Reply-To: <87k372n4m5.fsf@talisman.default> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg01753.txt.bz2 On 07/24/14 09:44, Richard Sandiford wrote: > Three targets had the same for_each_rtx function to check for a TLS symbol. > This patch adds a generic version instead. > > Some other targets have a variation that checks for target-specific > UNSPEC sequences too so I've left those alone. They're all prefixed > by the target name so there's no name clash or ambiguity. > > Tested on mips64-linux-gnu and via a cross-compiler for > powerpc64-linux-gnu and hppa64-hp-hpux11.23. OK to install? > > Thanks, > Richard > > > gcc/ > * rtl.h (tls_referenced_p): Declare. > * rtlanal.c (tls_referenced_p_1, tls_referenced_p): New functions. > * config/mips/mips.c (mips_tls_symbol_ref_1): Delete. > (mips_cannot_force_const_mem): Use tls_referenced_p. > * config/pa/pa-protos.h (pa_tls_referenced_p): Delete. > * config/pa/pa.h (CONSTANT_ADDRESS_P): Use tls_referenced_p > instead of pa_tls_referenced_p. > * config/pa/pa.c (hppa_legitimize_address, pa_cannot_force_const_mem) > (pa_emit_move_sequence, pa_emit_move_sequence): Likewise. > (pa_legitimate_constant_p): Likewise. > (pa_tls_symbol_ref_1, pa_tls_referenced_p): Delete. > * config/rs6000/rs6000.c (rs6000_tls_referenced_p): Delete. > (rs6000_cannot_force_const_mem, rs6000_emit_move) > (rs6000_address_for_altivec): Use tls_referenced_p instead of > rs6000_tls_referenced_p. > (rs6000_tls_symbol_ref_1): Delete. OK. Jeff