From: Jeff Law <law@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Tom Tromey <tromey@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [libcpp PATCH] Fix up location of builtin macros (PR c/61861)
Date: Fri, 25 Jul 2014 21:21:00 -0000 [thread overview]
Message-ID: <53D2C9AC.2090504@redhat.com> (raw)
In-Reply-To: <20140723131553.GD30336@redhat.com>
On 07/23/14 07:15, Marek Polacek wrote:
> Bultin macros like __FILE__, __DATE__, etc. had wrong locus - always
> column 1. This patch fixes it by giving those macros location
> of the expansion point, i.e, the location, where builtin macro is used.
> It now also does the correct thing if we do e.g.
> #define F __FILE__.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
>
> 2014-07-23 Marek Polacek <polacek@redhat.com>
>
> PR c/61861
> * macro.c (builtin_macro): Add location parameter. Set
> location of builtin macro to the expansion point.
> (enter_macro_context): Pass location to builtin_macro.
>
> * gcc.dg/pr61861.c: New test.
This is fine for the trunk.
Thanks,
jeff
prev parent reply other threads:[~2014-07-25 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 13:20 Marek Polacek
2014-07-23 15:44 ` Marek Polacek
2014-07-23 15:59 ` Marek Polacek
2014-07-25 21:21 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2C9AC.2090504@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).