From: Marat Zakirov <m.zakirov@samsung.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>,
Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Yury Gribov <y.gribov@samsung.com>
Subject: [PINGv2][PATCH] Fix for PR 61561
Date: Wed, 30 Jul 2014 13:07:00 -0000 [thread overview]
Message-ID: <53D8EB65.7040303@samsung.com> (raw)
In-Reply-To: <53CFB98D.50005@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
On 07/23/2014 05:33 PM, Marat Zakirov wrote:
> Hi all!
>
> This is a friendly reminder message.
>
> On 07/17/2014 03:22 PM, Marat Zakirov wrote:
>>
>> On 07/16/2014 01:32 PM, Kyrill Tkachov wrote:
>>>
>>> On 16/07/14 10:22, Marat Zakirov wrote:
>>>> Christophe,
>>>>
>>>> Please look at a new patch. Draft tests are OK.
>>>> I'll ask your commit approval when full regression (ARM/thumb1/thumb2)
>>>> tests are done.
>>> Hi Marat,
>>>
>>> I was about to propose the thumb2.md hunk myself, but I'll defer to
>>> the arm maintainers to comment on the other parts.
>>>
>>> Also, in the ChangeLog it is helpful to specify which patterns are
>>> being affected, so in your case it would be something like:
>>>
>>> * config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer.
>>> (*thumb1_movqi_insn): Likewise.
>>> * config/arm/thumb2.md (*thumb2_movhi_insn): Ditto.
>>>
>>>
>>> Kyrill
>>>
>>>
>> Christophe, Kirill,
>>
>> finally I've finished regression testing.
>> Please check if my patch is OK for trunk.
>>
>> The following configures were used:
>>
>> configure --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
>> --target=arm-linux-gnueabi --with-interwork --enable-long-long
>> --enable-languages=c,c++,fortran --enable-shared --with-gnu-as
>> --with-gnu-ld --with-arch=$ARCH --with-mode=$MODE
>>
>> Thumb-1
>>
>> $ARCH=armv4t
>> $MODE=thumb
>>
>> Thumb-2
>>
>> $ARCH=armv7
>> $MODE=thumb
>>
>> ARM
>>
>> $ARCH=armv7-a
>> $MODE=arm
>>
>> No regressions detected, test pr61561.c passed in all cases.
>>
>> Thank you all.
>> --Marat
>
>
[-- Attachment #2: thumb.diff --]
[-- Type: text/x-patch, Size: 1715 bytes --]
gcc/ChangeLog:
2014-07-16 Marat Zakirov <m.zakirov@samsung.com>
* config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer.
(*thumb1_movqi_insn): Likewise.
* config/arm/thumb2.md (*thumb2_movhi_insn): Likewise.
diff --git a/gcc/config/arm/thumb1.md b/gcc/config/arm/thumb1.md
index c044fd5..47b5cbd 100644
--- a/gcc/config/arm/thumb1.md
+++ b/gcc/config/arm/thumb1.md
@@ -708,7 +708,7 @@
(define_insn "*thumb1_movhi_insn"
[(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
- (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))]
+ (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))]
"TARGET_THUMB1
&& ( register_operand (operands[0], HImode)
|| register_operand (operands[1], HImode))"
@@ -762,7 +762,7 @@
(define_insn "*thumb1_movqi_insn"
[(set (match_operand:QI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
- (match_operand:QI 1 "general_operand" "l, m,l,*h,*r,I"))]
+ (match_operand:QI 1 "general_operand" "lk, m,l,*h,*r,I"))]
"TARGET_THUMB1
&& ( register_operand (operands[0], QImode)
|| register_operand (operands[1], QImode))"
diff --git a/gcc/config/arm/thumb2.md b/gcc/config/arm/thumb2.md
index 6ea0810..7228069 100644
--- a/gcc/config/arm/thumb2.md
+++ b/gcc/config/arm/thumb2.md
@@ -318,7 +318,7 @@
;; of the messiness associated with the ARM patterns.
(define_insn "*thumb2_movhi_insn"
[(set (match_operand:HI 0 "nonimmediate_operand" "=r,r,l,r,m,r")
- (match_operand:HI 1 "general_operand" "r,I,Py,n,r,m"))]
+ (match_operand:HI 1 "general_operand" "rk,I,Py,n,r,m"))]
"TARGET_THUMB2
&& (register_operand (operands[0], HImode)
|| register_operand (operands[1], HImode))"
next prev parent reply other threads:[~2014-07-30 12:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:21 [PING][PATCH] " Marat Zakirov
2014-07-10 12:57 ` [PING v2][PATCH] " Marat Zakirov
2014-07-10 13:01 ` [PING][PATCH] " Ramana Radhakrishnan
2014-07-11 9:09 ` Fwd: " Marat Zakirov
2014-07-11 19:19 ` Christophe Lyon
2014-07-14 7:45 ` Marat Zakirov
2014-07-14 9:07 ` Christophe Lyon
2014-07-16 9:24 ` Marat Zakirov
2014-07-16 9:36 ` Kyrill Tkachov
2014-07-17 12:18 ` Marat Zakirov
2014-07-23 13:47 ` Marat Zakirov
2014-07-30 13:07 ` Marat Zakirov [this message]
2014-08-06 14:12 ` [PINGv3][PATCH] " Marat Zakirov
2014-08-06 14:14 ` Ramana Radhakrishnan
2014-08-06 14:44 ` Richard Earnshaw
2014-08-07 7:37 ` Marat Zakirov
2014-08-07 8:01 ` Ramana Radhakrishnan
2014-08-07 8:11 ` Marat Zakirov
2014-08-07 8:50 ` Richard Earnshaw
2014-08-07 9:02 ` Marat Zakirov
2014-08-07 13:52 ` Marat Zakirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D8EB65.7040303@samsung.com \
--to=m.zakirov@samsung.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).