From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21852 invoked by alias); 31 Jul 2014 04:48:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21839 invoked by uid 89); 31 Jul 2014 04:48:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Jul 2014 04:47:58 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6V4lubK031469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 31 Jul 2014 00:47:56 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6V4lt0o004107; Thu, 31 Jul 2014 00:47:56 -0400 Message-ID: <53D9CA7B.3040709@redhat.com> Date: Thu, 31 Jul 2014 04:49:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Tom Tromey , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 5/5] add libcc1 References: <1400254001-12038-1-git-send-email-tromey@redhat.com> <87oayx4l0x.fsf@fleche.redhat.com> <87bntobp1f.fsf@fleche.redhat.com> In-Reply-To: <87bntobp1f.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg02153.txt.bz2 On 06/19/14 14:52, Tom Tromey wrote: > Tom> I've edited this one down by removing the auto-generated stuff , and > Tom> then compressed it. > > Here's a new version of patch #5. > I've removed the generated code; let's see if it gets through without > compression. > > I think this addresses all the reviews: > > * It uses gcc-plugin.m4 to disable the plugin > * It does some configure checks for needed functionality, and disables > the plugin if they are not found > * libcc1 and the plugin now do a protocol version handshake at > startup > * The diagnostic overriding code is now in the plugin, not in gcc proper > * gdb now tells libcc1 about the target triplet, and libcc1 uses > this to invoke the proper GCC. This is done by (ewww) searching $PATH. > > Tom > > 2014-06-19 Phil Muldoon > Tom Tromey > > * Makefile.def: Add libcc1 to host_modules. > * configure.ac (host_tools): Add libcc1. > * Makefile.in, configure: Rebuild. > > 2014-06-19 Phil Muldoon > Jan Kratochvil > Tom Tromey > > * aclocal.m4: New file. > * callbacks.cc: New file. > * callbacks.hh: New file. > * cc1plugin-config.h.in: New file. > * configure: New file. > * configure.ac: New file. > * connection.cc: New file. > * connection.hh: New file. > * findcomp.cc: New file. > * findcomp.hh: New file. > * libcc1.cc: New file. > * libcc1plugin.sym: New file. > * libcc1.sym: New file. > * Makefile.am: New file. > * Makefile.in: New file. > * marshall.cc: New file. > * marshall.hh: New file. > * names.cc: New file. > * names.hh: New file. > * plugin.cc: New file. > * rpc.hh: New file. > * status.hh: New file. So my biggest concern here is long term maintenance -- who's going to own care and feeding of these bits over time. My inclination is to go ahead and approve, but explicitly note that if the bits do start to rot that we'll be fairly aggressive at disabling/removing them. Now that my position is out there for everyone to see, give the other maintainers a few days (say until Monday) to chime in with any objections. Obviously if there are no objections and you check in the change, please be on the lookout for any fallout. I'm particularly concerned about AIX, Solaris and other non-linux platforms. Does this deserve a mention in the news file? Jeff