From: Jeff Law <law@redhat.com>
To: Yury Gribov <y.gribov@samsung.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Konstantin Serebryany <kcc@gcc.gnu.org>,
Andrey Ryabinin <a.ryabinin@samsung.com>
Subject: Re: [PATCH][PING] Add support for KernelAddressSanitizer
Date: Thu, 31 Jul 2014 04:53:00 -0000 [thread overview]
Message-ID: <53D9CAF1.3050101@redhat.com> (raw)
In-Reply-To: <53D90279.3060108@samsung.com>
On 07/30/14 08:34, Yury Gribov wrote:
> On 07/18/2014 05:38 PM, Jakub Jelinek wrote:
>>>> Do you error out on -fsanitize=thread -fsanitize=kernel-address ?
>>>> Perhaps -fsanitize=kernel-address -fsanitize=address should be
>>>> invalid too?
>>>
>>> Yes, all these combinations are invalid.
>>
>> But you don't error out on that.
>
> Ok, fixed.
>
>> Then in sanitize_spec_function supposedly for "address" check
>> SANITIZE_USER_ADDRESS bit, for "kernel-address" added there
>> SANITIZE_KERNEL_ADDRESS, add all the incompatibility diagnostics for
>> the new
>> invalid combinations.
>
> This delayed detection until link phase (and even then was disabled if
> -nostdlib was on)
> so I decided to perform this check in finish_options (after passing
> cmdline options).
>
>> Plus, toplev.c has e.g.:
>
> Fixed as well.
This is fine. Thanks,
Jeff
next prev parent reply other threads:[~2014-07-31 4:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 11:58 [PATCH] " Yury Gribov
2014-07-18 12:44 ` Dmitry Vyukov
2014-07-18 13:20 ` Jakub Jelinek
2014-07-18 13:31 ` Dmitry Vyukov
2014-07-18 13:35 ` Yury Gribov
2014-07-18 14:05 ` Jakub Jelinek
2014-07-18 14:20 ` Yury Gribov
2014-07-23 14:36 ` Yury Gribov
2014-07-30 14:42 ` [PATCH][PING] " Yury Gribov
2014-07-31 4:53 ` Jeff Law [this message]
2014-07-31 13:36 ` Yury Gribov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D9CAF1.3050101@redhat.com \
--to=law@redhat.com \
--cc=a.ryabinin@samsung.com \
--cc=dvyukov@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kcc@gcc.gnu.org \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).