From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23293 invoked by alias); 5 Aug 2014 20:18:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23270 invoked by uid 89); 5 Aug 2014 20:18:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Aug 2014 20:18:19 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75KIH3A020694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Aug 2014 16:18:17 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s75KIGSI024086; Tue, 5 Aug 2014 16:18:17 -0400 Message-ID: <53E13C08.3030202@redhat.com> Date: Tue, 05 Aug 2014 20:18:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Alexander Ivchenko , GCC Patches , Jakub Jelinek , Igor Zamyatin Subject: Re: Fix build of *86*-linux-android with "--enable-shared" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00373.txt.bz2 On 08/04/14 00:08, Alexander Ivchenko wrote: > Hi, > > libcilkrts is compiled with "-nostdlib", that means we have to > explicitly specify the pthread library we should link with (e.g. we > don't have such problem with libgomp, because it is C). And, indeed, > "-lpthread" is hard-coded in the Makefile for cilkrts. For Android > this doesn't work, because lpthread is absent and pthreads are part of > libc. > > I also noticed, that configure check for > "pthread_{,attr_}[sg]etaffinity_np" always fails, because at the point > where it is placed in configure.ac, "-pthread" is not set. We just > have to put this check after we added "-pthread" to CFLAGS. This patch > addresses this as well. > > > > diff --git a/libcilkrts/ChangeLog b/libcilkrts/ChangeLog > index 3881c82..ab10a0b 100644 > --- a/libcilkrts/ChangeLog > +++ b/libcilkrts/ChangeLog > @@ -1,3 +1,15 @@ > +2014-08-01 Alexander Ivchenko > + > + * configure.ac: Move pthread affinity test to the place where > + '-pthread' passed to CFLAGS. Otherwise the test always fails. > + (XCFLAGS): New variable for correctly passing > + '-pthread'. > + (XLDFLAGS): New variable for passing the correct pthread lib. > + * configure: Regenerate. > + * Makefile.am (AM_CFLAGS): Add $XCFLAGS. > + (AM_LDFLAGS): Add $XLDFLAGS. > + * Makefile.in: Regenerate. So can you confirm that you've bootstrapped this on x86_64-unknown-linux-gnu and that there were no regressions? Also double-check the indention in the ChangeLog entry, though it may just be your mailer that has mucked that up. Once the bootstrap and regression test are OK, this is OK. jeff