From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19507 invoked by alias); 5 Aug 2014 20:54:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19494 invoked by uid 89); 5 Aug 2014 20:54:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Aug 2014 20:54:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75KsfRo008032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Aug 2014 16:54:41 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s75KsenJ024614; Tue, 5 Aug 2014 16:54:41 -0400 Message-ID: <53E14490.20809@redhat.com> Date: Tue, 05 Aug 2014 20:54:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: Re: [PATCH 04/50] caller-save.c:add_used_regs References: <87y4v5d77q.fsf@googlemail.com> <87ha1td6qy.fsf@googlemail.com> In-Reply-To: <87ha1td6qy.fsf@googlemail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00378.txt.bz2 On 08/03/14 07:48, Richard Sandiford wrote: > As noted in https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01391.html > a bitmap-related cleanup turned add_used_regs_1 into a no-op for pseudo > registers, because the result of: > > regno = reg_renumber[regno]; > > is never used. This patch does as Steven requested and adds an > assert that no allocated pseudos are seen here. > > > gcc/ > * caller-save.c: Include rtl-iter.h. > (add_used_regs_1): Delete. > (add_used_regs): Use FOR_EACH_SUBRTX rather than for_each_rtx > to iterate over subrtxes. Assert that any remaining pseudos > have been spilled. OK. jeff