From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10562 invoked by alias); 5 Aug 2014 22:15:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10525 invoked by uid 89); 5 Aug 2014 22:15:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Aug 2014 22:15:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75MFEud023998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Aug 2014 18:15:14 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s75MFDbJ017083; Tue, 5 Aug 2014 18:15:13 -0400 Message-ID: <53E15771.3030605@redhat.com> Date: Tue, 05 Aug 2014 22:15:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: Re: [PATCH 50/50] varasm.c:compute_reloc_for_rtx References: <87y4v5d77q.fsf@googlemail.com> <87y4v54opd.fsf@googlemail.com> In-Reply-To: <87y4v54opd.fsf@googlemail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00416.txt.bz2 On 08/03/14 08:45, Richard Sandiford wrote: > There's no point calling for_each_rtx/FOR_EACH_SUBRTX on a LABEL_REF > or SYMBOL_REF. We can just handle them directly instead. > > > gcc/ > * varasm.c (compute_reloc_for_rtx_1): Take a const_rtx. Remove the > pointer to the cumulative reloc value and return the value for > this reloc instead. > (compute_reloc_for_rtx): Take a const_rtx. Call > compute_reloc_for_rtx_1 directly for SYMBOL_REF and LABEL_REF, > avoiding any recursion. Use FOR_EACH_SUBRTX rather than > for_each_rtx for the CONST case. OK. Jeff