From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15363 invoked by alias); 5 Aug 2014 22:18:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15349 invoked by uid 89); 5 Aug 2014 22:18:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Aug 2014 22:18:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75MI8Do019980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Aug 2014 18:18:08 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s75MI8O3014583; Tue, 5 Aug 2014 18:18:08 -0400 Message-ID: <53E15820.2000106@redhat.com> Date: Tue, 05 Aug 2014 22:18:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: Re: [PATCH 48/50] varasm.c:const_rtx_hash References: <87y4v5d77q.fsf@googlemail.com> <877g2p63ds.fsf@googlemail.com> In-Reply-To: <877g2p63ds.fsf@googlemail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00418.txt.bz2 On 08/03/14 08:42, Richard Sandiford wrote: > const_rtx_hash_1 had code to hash all elements of a CONST_VECTOR, > but const_rtx_hash also hashes all subrtxes, so we'd end up hashing > the same thing twice. This looked unintentional so I just removed the > CONST_VECTOR case. If instead it was a deliberate decision then I think > it deserves a comment. > > > gcc/ > * varasm.c: Include rtl-iter.h. > (const_rtx_hash_1): Take a const_rtx rather than an rtx *. > Remove the pointer to the cumulative hashval_t and just return > the hash for this rtx instead. Remove recursive CONST_VECTOR case. > (const_rtx_hash): Use FOR_EACH_SUBRTX instead of for_each_rtx. > Accumulate the hashval_ts here instead of const_rtx_hash_1. This is fine. Though I wonder if it's going to conflict with Andi's work on inchash. If so, consider adjustments to handle Andi's changes pre-approved. Just post the final patch for archival purposes if you need to change it. Thanks, jeff