From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10012 invoked by alias); 6 Aug 2014 14:12:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10002 invoked by uid 89); 6 Aug 2014 14:12:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mailout3.w1.samsung.com Received: from mailout3.w1.samsung.com (HELO mailout3.w1.samsung.com) (210.118.77.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 14:12:36 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N9W0021424VLD50@mailout3.w1.samsung.com> for gcc-patches@gcc.gnu.org; Wed, 06 Aug 2014 15:12:31 +0100 (BST) Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 5F.34.15956.FC732E35; Wed, 06 Aug 2014 15:12:31 +0100 (BST) Received: from [106.109.129.103] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N9W00D5X24UJL20@eusync3.samsung.com>; Wed, 06 Aug 2014 15:12:31 +0100 (BST) Message-id: <53E237CE.7050702@samsung.com> Date: Wed, 06 Aug 2014 14:12:00 -0000 From: Marat Zakirov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-version: 1.0 To: "gcc-patches@gcc.gnu.org" Cc: Kyrill Tkachov , Christophe Lyon , Ramana Radhakrishnan , Richard Earnshaw , Slava Garbuzov , Yury Gribov Subject: [PINGv3][PATCH] Fix for PR 61561 References: <53BE8EA4.7080803@arm.com> <53BFA9A9.4090209@samsung.com> <53C64468.9000506@samsung.com> <53C646BB.6020905@arm.com> <53C7B202.3070401@samsung.com> <53CFB98D.50005@samsung.com> <53D8EB65.7040303@samsung.com> In-reply-to: <53D8EB65.7040303@samsung.com> Content-type: multipart/mixed; boundary=------------060804000407060908070206 X-SW-Source: 2014-08/txt/msg00472.txt.bz2 This is a multi-part message in MIME format. --------------060804000407060908070206 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1688 On 07/30/2014 04:56 PM, Marat Zakirov wrote: > On 07/23/2014 05:33 PM, Marat Zakirov wrote: >> Hi all! >> >> This is a friendly reminder message. >> >> On 07/17/2014 03:22 PM, Marat Zakirov wrote: >>> >>> On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: >>>> >>>> On 16/07/14 10:22, Marat Zakirov wrote: >>>>> Christophe, >>>>> >>>>> Please look at a new patch. Draft tests are OK. >>>>> I'll ask your commit approval when full regression >>>>> (ARM/thumb1/thumb2) >>>>> tests are done. >>>> Hi Marat, >>>> >>>> I was about to propose the thumb2.md hunk myself, but I'll defer to >>>> the arm maintainers to comment on the other parts. >>>> >>>> Also, in the ChangeLog it is helpful to specify which patterns are >>>> being affected, so in your case it would be something like: >>>> >>>> * config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer. >>>> (*thumb1_movqi_insn): Likewise. >>>> * config/arm/thumb2.md (*thumb2_movhi_insn): Ditto. >>>> >>>> >>>> Kyrill >>>> >>>> >>> Christophe, Kirill, >>> >>> finally I've finished regression testing. >>> Please check if my patch is OK for trunk. >>> >>> The following configures were used: >>> >>> configure --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu >>> --target=arm-linux-gnueabi --with-interwork --enable-long-long >>> --enable-languages=c,c++,fortran --enable-shared --with-gnu-as >>> --with-gnu-ld --with-arch=$ARCH --with-mode=$MODE >>> >>> Thumb-1 >>> >>> $ARCH=armv4t >>> $MODE=thumb >>> >>> Thumb-2 >>> >>> $ARCH=armv7 >>> $MODE=thumb >>> >>> ARM >>> >>> $ARCH=armv7-a >>> $MODE=arm >>> >>> No regressions detected, test pr61561.c passed in all cases. >>> >>> Thank you all. >>> --Marat >> >> > --------------060804000407060908070206 Content-Type: text/x-patch; name="thumb.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="thumb.diff" Content-length: 1715 gcc/ChangeLog: 2014-07-16 Marat Zakirov * config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer. (*thumb1_movqi_insn): Likewise. * config/arm/thumb2.md (*thumb2_movhi_insn): Likewise. diff --git a/gcc/config/arm/thumb1.md b/gcc/config/arm/thumb1.md index c044fd5..47b5cbd 100644 --- a/gcc/config/arm/thumb1.md +++ b/gcc/config/arm/thumb1.md @@ -708,7 +708,7 @@ (define_insn "*thumb1_movhi_insn" [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l") - (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))] + (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))] "TARGET_THUMB1 && ( register_operand (operands[0], HImode) || register_operand (operands[1], HImode))" @@ -762,7 +762,7 @@ (define_insn "*thumb1_movqi_insn" [(set (match_operand:QI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l") - (match_operand:QI 1 "general_operand" "l, m,l,*h,*r,I"))] + (match_operand:QI 1 "general_operand" "lk, m,l,*h,*r,I"))] "TARGET_THUMB1 && ( register_operand (operands[0], QImode) || register_operand (operands[1], QImode))" diff --git a/gcc/config/arm/thumb2.md b/gcc/config/arm/thumb2.md index 6ea0810..7228069 100644 --- a/gcc/config/arm/thumb2.md +++ b/gcc/config/arm/thumb2.md @@ -318,7 +318,7 @@ ;; of the messiness associated with the ARM patterns. (define_insn "*thumb2_movhi_insn" [(set (match_operand:HI 0 "nonimmediate_operand" "=r,r,l,r,m,r") - (match_operand:HI 1 "general_operand" "r,I,Py,n,r,m"))] + (match_operand:HI 1 "general_operand" "rk,I,Py,n,r,m"))] "TARGET_THUMB2 && (register_operand (operands[0], HImode) || register_operand (operands[1], HImode))" --------------060804000407060908070206--