From: Richard Earnshaw <rearnsha@arm.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Cc: Marat Zakirov <m.zakirov@samsung.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Christophe Lyon <christophe.lyon@linaro.org>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Yury Gribov <y.gribov@samsung.com>
Subject: Re: [PINGv3][PATCH] Fix for PR 61561
Date: Wed, 06 Aug 2014 14:44:00 -0000 [thread overview]
Message-ID: <53E23F38.5020400@arm.com> (raw)
In-Reply-To: <53E23832.4070707@arm.com>
On 06/08/14 15:14, Ramana Radhakrishnan wrote:
>
>
> This is OK thanks.
>
>
> Ramana
>
Hmm, minor nit.
(define_insn "*thumb1_movhi_insn"
[(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
- (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))]
+ (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))]
This would be better expressed as:
[(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l")
(match_operand:HI 1 "general_operand" "l,m,l,k*h,*r,I"))]
that is, to use the 4th alternative. That's because the use of SP in
these operations does not clobber the flags.
Similarly for the movqi pattern.
R.
next prev parent reply other threads:[~2014-08-06 14:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:21 [PING][PATCH] " Marat Zakirov
2014-07-10 12:57 ` [PING v2][PATCH] " Marat Zakirov
2014-07-10 13:01 ` [PING][PATCH] " Ramana Radhakrishnan
2014-07-11 9:09 ` Fwd: " Marat Zakirov
2014-07-11 19:19 ` Christophe Lyon
2014-07-14 7:45 ` Marat Zakirov
2014-07-14 9:07 ` Christophe Lyon
2014-07-16 9:24 ` Marat Zakirov
2014-07-16 9:36 ` Kyrill Tkachov
2014-07-17 12:18 ` Marat Zakirov
2014-07-23 13:47 ` Marat Zakirov
2014-07-30 13:07 ` [PINGv2][PATCH] " Marat Zakirov
2014-08-06 14:12 ` [PINGv3][PATCH] " Marat Zakirov
2014-08-06 14:14 ` Ramana Radhakrishnan
2014-08-06 14:44 ` Richard Earnshaw [this message]
2014-08-07 7:37 ` Marat Zakirov
2014-08-07 8:01 ` Ramana Radhakrishnan
2014-08-07 8:11 ` Marat Zakirov
2014-08-07 8:50 ` Richard Earnshaw
2014-08-07 9:02 ` Marat Zakirov
2014-08-07 13:52 ` Marat Zakirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E23F38.5020400@arm.com \
--to=rearnsha@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=m.zakirov@samsung.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).