Re: [C++ Patch/RFC] PR 43906

[Paolo Carlini <paolo.carlini@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

Hi,

On 08/06/2014 05:19 PM, Jason Merrill wrote:
> On 08/05/2014 10:48 AM, Paolo Carlini wrote:
>> +           && (VOID_TYPE_P (TREE_TYPE (type1))
>> +               || comptypes (TYPE_MAIN_VARIANT (TREE_TYPE (type0)),
>> +                     TYPE_MAIN_VARIANT (TREE_TYPE (type1)),
>> +                     COMPARE_BASE | COMPARE_DERIVED))))
>
> Can we drop this now that we're calling composite_pointer_type?
Yes we can, sorry for not investigating that earlier. I only have to 
tweak a bit the testcase because then in the malformed cases we emit 
first the permerror and then the -Waddress warning too. I suppose it's 
Ok because after all those are in most of the cases permerrors and I 
don't think the additional verbosity should be that common, we are 
talking about comparing a "null" pointer of the wrong type, not a 
generic pointer. Otherwise we would have to tweak composite_pointer_type 
to precisely inform the caller when an actual error was emitted.

Thanks,
Paolo.

/////////////////////

[-- Attachment #2: patch_43906_5 --]
[-- Type: text/plain, Size: 5151 bytes --]

Index: cp/typeck.c
===================================================================
--- cp/typeck.c	(revision 213654)
+++ cp/typeck.c	(working copy)
@@ -4353,13 +4353,18 @@ cp_build_binary_op (location_t location,
 	  && (code1 == INTEGER_TYPE || code1 == REAL_TYPE
 	      || code1 == COMPLEX_TYPE || code1 == ENUMERAL_TYPE))
 	short_compare = 1;
-      else if ((code0 == POINTER_TYPE && code1 == POINTER_TYPE)
-	       || (TYPE_PTRDATAMEM_P (type0) && TYPE_PTRDATAMEM_P (type1)))
-	result_type = composite_pointer_type (type0, type1, op0, op1,
-					      CPO_COMPARISON, complain);
-      else if ((code0 == POINTER_TYPE || TYPE_PTRDATAMEM_P (type0))
-	       && null_ptr_cst_p (op1))
+      else if (((code0 == POINTER_TYPE || TYPE_PTRDATAMEM_P (type0))
+		&& null_ptr_cst_p (op1))
+	       /* Handle, eg, (void*)0 (c++/43906), and more.  */
+	       || (code0 == POINTER_TYPE
+		   && TYPE_PTR_P (type1) && integer_zerop (op1)))
 	{
+	  if (TYPE_PTR_P (type1))
+	    result_type = composite_pointer_type (type0, type1, op0, op1,
+						  CPO_COMPARISON, complain);
+	  else
+	    result_type = type0;
+
 	  if (TREE_CODE (op0) == ADDR_EXPR
 	      && decl_with_nonnull_addr_p (TREE_OPERAND (op0, 0)))
 	    {
@@ -4368,11 +4373,19 @@ cp_build_binary_op (location_t location,
 		warning (OPT_Waddress, "the address of %qD will never be NULL",
 			 TREE_OPERAND (op0, 0));
 	    }
-	  result_type = type0;
 	}
-      else if ((code1 == POINTER_TYPE || TYPE_PTRDATAMEM_P (type1))
-	       && null_ptr_cst_p (op0))
+      else if (((code1 == POINTER_TYPE || TYPE_PTRDATAMEM_P (type1))
+		&& null_ptr_cst_p (op0))
+	       /* Handle, eg, (void*)0 (c++/43906), and more.  */
+	       || (code1 == POINTER_TYPE
+		   && TYPE_PTR_P (type0) && integer_zerop (op0)))
 	{
+	  if (TYPE_PTR_P (type0))
+	    result_type = composite_pointer_type (type0, type1, op0, op1,
+						  CPO_COMPARISON, complain);
+	  else
+	    result_type = type1;
+
 	  if (TREE_CODE (op1) == ADDR_EXPR 
 	      && decl_with_nonnull_addr_p (TREE_OPERAND (op1, 0)))
 	    {
@@ -4381,8 +4394,11 @@ cp_build_binary_op (location_t location,
 		warning (OPT_Waddress, "the address of %qD will never be NULL",
 			 TREE_OPERAND (op1, 0));
 	    }
-	  result_type = type1;
 	}
+      else if ((code0 == POINTER_TYPE && code1 == POINTER_TYPE)
+	       || (TYPE_PTRDATAMEM_P (type0) && TYPE_PTRDATAMEM_P (type1)))
+	result_type = composite_pointer_type (type0, type1, op0, op1,
+					      CPO_COMPARISON, complain);
       else if (null_ptr_cst_p (op0) && null_ptr_cst_p (op1))
 	/* One of the operands must be of nullptr_t type.  */
         result_type = TREE_TYPE (nullptr_node);
Index: testsuite/g++.dg/warn/Waddress-1.C
===================================================================
--- testsuite/g++.dg/warn/Waddress-1.C	(revision 0)
+++ testsuite/g++.dg/warn/Waddress-1.C	(working copy)
@@ -0,0 +1,50 @@
+// PR c++/43906
+// { dg-options "-Waddress -pedantic" }
+
+extern void z();
+typedef void (*ptrf) ();
+typedef int (*ptrfn) (int);
+int n;
+const int m = 1;
+struct S { };
+struct T : S { };
+struct U;
+S s;
+T t;
+double d;
+
+void f()  { if (z) z(); }               // { dg-warning "address" }
+
+void gl() { if (z != 0) z(); }          // { dg-warning "address" }
+void hl() { if (z != (ptrf)0) z(); }    // { dg-warning "address" }
+void il() { if (z != (void*)0) z(); }   // { dg-warning "address|comparison" }
+void jl() { if (&n != (int*)0) z(); }   // { dg-warning "address" }
+void kl() { if (&m != (int*)0) z(); }   // { dg-warning "address" }
+void ll() { if (&s != (T*)0) z(); }     // { dg-warning "address" }
+void ml() { if (&t != (S*)0) z(); }     // { dg-warning "address" }
+
+void nl() { if (z != (S*)0) z(); }      // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 26 }
+void pl() { if (z != (ptrfn)0) z(); }   // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 28 }
+void ql() { if (&d != (int*)0) z(); }   // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 30 }
+void rl() { if (&s != (U*)0) z(); }     // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 32 }
+
+void gr() { if (0 != z) z(); }          // { dg-warning "address" }
+void hr() { if ((ptrf)0 != z) z(); }    // { dg-warning "address" }
+void ir() { if ((void*)0 != z) z(); }   // { dg-warning "address|comparison" }
+void jr() { if ((int*)0 != &n) z(); }   // { dg-warning "address" }
+void kr() { if ((int*)0 != &m) z(); }   // { dg-warning "address" }
+void lr() { if ((T*)0 != &s) z(); }     // { dg-warning "address" }
+void mr() { if ((S*)0 != &t) z(); }     // { dg-warning "address" }
+
+void nr() { if ((S*)0 != z) z(); }      // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 43 }
+void pr() { if ((ptrfn)0 != z) z(); }   // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 45 }
+void qr() { if ((int*)0 != &d) z(); }   // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 47 }
+void rr() { if ((U*)0 != &s) z(); }     // { dg-error "comparison" }
+// { dg-warning "address" "" { target *-*-* } 49 }