From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28598 invoked by alias); 7 Aug 2014 07:37:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28577 invoked by uid 89); 7 Aug 2014 07:37:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mailout4.w1.samsung.com Received: from mailout4.w1.samsung.com (HELO mailout4.w1.samsung.com) (210.118.77.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Thu, 07 Aug 2014 07:37:03 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N9X0013DEHCGA50@mailout4.w1.samsung.com> for gcc-patches@gcc.gnu.org; Thu, 07 Aug 2014 08:36:48 +0100 (BST) Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 6D.4B.15956.A9C23E35; Thu, 07 Aug 2014 08:36:58 +0100 (BST) Received: from [106.109.129.103] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N9X00G8GEHMMC80@eusync3.samsung.com>; Thu, 07 Aug 2014 08:36:58 +0100 (BST) Message-id: <53E32C99.9020202@samsung.com> Date: Thu, 07 Aug 2014 07:37:00 -0000 From: Marat Zakirov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-version: 1.0 To: Richard Earnshaw , Ramana Radhakrishnan Cc: "gcc-patches@gcc.gnu.org" , Kyrylo Tkachov , Christophe Lyon , Slava Garbuzov , Yury Gribov Subject: Re: [PINGv3][PATCH] Fix for PR 61561 References: <53BE8EA4.7080803@arm.com> <53BFA9A9.4090209@samsung.com> <53C64468.9000506@samsung.com> <53C646BB.6020905@arm.com> <53C7B202.3070401@samsung.com> <53CFB98D.50005@samsung.com> <53D8EB65.7040303@samsung.com> <53E237CE.7050702@samsung.com> <53E23832.4070707@arm.com> <53E23F38.5020400@arm.com> In-reply-to: <53E23F38.5020400@arm.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-SW-Source: 2014-08/txt/msg00763.txt.bz2 Thank you. $ svn commit Sending gcc/ChangeLog Sending gcc/config/arm/thumb1.md Sending gcc/config/arm/thumb2.md Transmitting file data ... Committed revision 213695. P.S. Minor nit was reg. tested. On 08/06/2014 06:44 PM, Richard Earnshaw wrote: > On 06/08/14 15:14, Ramana Radhakrishnan wrote: >> >> This is OK thanks. >> >> >> Ramana >> > > Hmm, minor nit. > > (define_insn "*thumb1_movhi_insn" > [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l") > - (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))] > + (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))] > > This would be better expressed as: > > [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l") > (match_operand:HI 1 "general_operand" "l,m,l,k*h,*r,I"))] > > that is, to use the 4th alternative. That's because the use of SP in > these operations does not clobber the flags. > > Similarly for the movqi pattern. > > R. > >