From: Marat Zakirov <m.zakirov@samsung.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Christophe Lyon <christophe.lyon@linaro.org>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Yury Gribov <y.gribov@samsung.com>
Subject: Re: [PINGv3][PATCH] Fix for PR 61561
Date: Thu, 07 Aug 2014 13:52:00 -0000 [thread overview]
Message-ID: <53E384A8.2090705@samsung.com> (raw)
In-Reply-To: <53E34089.7020909@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 4215 bytes --]
Sending gcc/ChangeLog
Sending gcc/config/arm/thumb1.md
Transmitting file data ..
Committed revision 213710.
P.S. Sorry for inconvenience.
On 08/07/2014 01:02 PM, Marat Zakirov wrote:
> Sorry ;( Will test&fix it.
>
> On 08/07/2014 12:50 PM, Richard Earnshaw wrote:
>>>>> On 08/06/2014 06:44 PM, Richard Earnshaw wrote:
>>>>>> Similarly for the movqi pattern.
>>
>> You haven't updated the thumb1 QImode pattern in the same way.
>>
>> R.
>>
>> On 07/08/14 09:10, Marat Zakirov wrote:
>>> --Marat
>>> On 08/07/2014 12:00 PM, Ramana Radhakrishnan wrote:
>>>> On Thu, Aug 7, 2014 at 8:36 AM, Marat Zakirov
>>>> <m.zakirov@samsung.com> wrote:
>>>>> Thank you.
>>>>>
>>>>> $ svn commit
>>>>> Sending gcc/ChangeLog
>>>>> Sending gcc/config/arm/thumb1.md
>>>>> Sending gcc/config/arm/thumb2.md./gcc/config/arm/thumb1.md
>>>>> Transmitting file data ...
>>>>> Committed revision 213695.
>>>>>
>>>>> P.S.
>>>>>
>>>>> Minor nit was reg. tested.
>>>> Another minor nit - please send the patch you committed to be archived
>>>> on the mailing list.
>>>>
>>>> regards
>>>> Ramana
>>>>
>>>>> On 08/06/2014 06:44 PM, Richard Earnshaw wrote:
>>>>>> On 06/08/14 15:14, Ramana Radhakrishnan wrote:
>>>>>>> This is OK thanks.
>>>>>>>
>>>>>>>
>>>>>>> Ramana
>>>>>>>
>>>>>> Hmm, minor nit.
>>>>>>
>>>>>> (define_insn "*thumb1_movhi_insn"
>>>>>> [(set (match_operand:HI 0 "nonimmediate_operand"
>>>>>> "=l,l,m,*r,*h,l")
>>>>>> - (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))]
>>>>>> + (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))]
>>>>>>
>>>>>> This would be better expressed as:
>>>>>>
>>>>>> [(set (match_operand:HI 0 "nonimmediate_operand"
>>>>>> "=l,l,m,l*r,*h,l")
>>>>>> (match_operand:HI 1 "general_operand" "l,m,l,k*h,*r,I"))]
>>>>>>
>>>>>> that is, to use the 4th alternative. That's because the use of
>>>>>> SP in
>>>>>> these operations does not clobber the flags.
>>>>>>
>>>>>> Similarly for the movqi pattern.
>>>>>>
>>>>>> R.
>>>>>>
>>>>>>
>>>>>>
>>>>>> thumb2.diff
>>>>>>
>>>>>>
>>>>>> gcc/ChangeLog:
>>>>>>
>>>>>> 2014-08-07 Marat Zakirov <m.zakirov@samsung.com>
>>>>>>
>>>>>> * config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack
>>>>>> pointer.
>>>>>> (*thumb1_movqi_insn): Likewise.
>>>>>> * config/arm/thumb2.md (*thumb2_movhi_insn): Likewise.
>>>>>>
>>>>>> diff --git a/gcc/config/arm/thumb1.md b/gcc/config/arm/thumb1.md
>>>>>> index cd1adf4..fed741e 100644
>>>>>> --- a/gcc/config/arm/thumb1.md
>>>>>> +++ b/gcc/config/arm/thumb1.md
>>>>>> @@ -707,8 +707,8 @@
>>>>>> )
>>>>>> (define_insn "*thumb1_movhi_insn"
>>>>>> - [(set (match_operand:HI 0 "nonimmediate_operand"
>>>>>> "=l,l,m,*r,*h,l")
>>>>>> - (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))]
>>>>>> + [(set (match_operand:HI 0 "nonimmediate_operand"
>>>>>> "=l,l,m,l*r,*h,l")
>>>>>> + (match_operand:HI 1 "general_operand" "l,m,l,k*h,*r,I"))]
>>>>>> "TARGET_THUMB1
>>>>>> && ( register_operand (operands[0], HImode)
>>>>>> || register_operand (operands[1], HImode))"
>>>>>> @@ -762,7 +762,7 @@
>>>>>> (define_insn "*thumb1_movqi_insn"
>>>>>> [(set (match_operand:QI 0 "nonimmediate_operand"
>>>>>> "=l,l,m,*r,*h,l")
>>>>>> - (match_operand:QI 1 "general_operand" "l, m,l,*h,*r,I"))]
>>>>>> + (match_operand:QI 1 "general_operand" "lk, m,l,*h,*r,I"))]
>>>>>> "TARGET_THUMB1
>>>>>> && ( register_operand (operands[0], QImode)
>>>>>> || register_operand (operands[1], QImode))"
>>>>>> diff --git a/gcc/config/arm/thumb2.md b/gcc/config/arm/thumb2.md
>>>>>> index 029a679..983b59d 100644
>>>>>> --- a/gcc/config/arm/thumb2.md
>>>>>> +++ b/gcc/config/arm/thumb2.md
>>>>>> @@ -318,7 +318,7 @@
>>>>>> ;; of the messiness associated with the ARM patterns.
>>>>>> (define_insn "*thumb2_movhi_insn"
>>>>>> [(set (match_operand:HI 0 "nonimmediate_operand" "=r,r,l,r,m,r")
>>>>>> - (match_operand:HI 1 "general_operand" "r,I,Py,n,r,m"))]
>>>>>> + (match_operand:HI 1 "general_operand" "rk,I,Py,n,r,m"))]
>>>>>> "TARGET_THUMB2
>>>>>> && (register_operand (operands[0], HImode)
>>>>>> || register_operand (operands[1], HImode))"
>>
>>
>
[-- Attachment #2: thumb3.diff --]
[-- Type: text/x-patch, Size: 686 bytes --]
gcc/ChangeLog:
2014-08-07 Marat Zakirov <m.zakirov@samsung.com>
* config/arm/thumb1.md (*thumb1_movqi_insn): Copy of thumb1_movhi_insn.
--- gcc/config/arm/thumb1.md (revision 213695)
+++ gcc/config/arm/thumb1.md (working copy)
@@ -761,8 +761,8 @@
)
(define_insn "*thumb1_movqi_insn"
- [(set (match_operand:QI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
- (match_operand:QI 1 "general_operand" "lk, m,l,*h,*r,I"))]
+ [(set (match_operand:QI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l")
+ (match_operand:QI 1 "general_operand" "l,m,l,k*h,*r,I"))]
"TARGET_THUMB1
&& ( register_operand (operands[0], QImode)
|| register_operand (operands[1], QImode))"
prev parent reply other threads:[~2014-08-07 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:21 [PING][PATCH] " Marat Zakirov
2014-07-10 12:57 ` [PING v2][PATCH] " Marat Zakirov
2014-07-10 13:01 ` [PING][PATCH] " Ramana Radhakrishnan
2014-07-11 9:09 ` Fwd: " Marat Zakirov
2014-07-11 19:19 ` Christophe Lyon
2014-07-14 7:45 ` Marat Zakirov
2014-07-14 9:07 ` Christophe Lyon
2014-07-16 9:24 ` Marat Zakirov
2014-07-16 9:36 ` Kyrill Tkachov
2014-07-17 12:18 ` Marat Zakirov
2014-07-23 13:47 ` Marat Zakirov
2014-07-30 13:07 ` [PINGv2][PATCH] " Marat Zakirov
2014-08-06 14:12 ` [PINGv3][PATCH] " Marat Zakirov
2014-08-06 14:14 ` Ramana Radhakrishnan
2014-08-06 14:44 ` Richard Earnshaw
2014-08-07 7:37 ` Marat Zakirov
2014-08-07 8:01 ` Ramana Radhakrishnan
2014-08-07 8:11 ` Marat Zakirov
2014-08-07 8:50 ` Richard Earnshaw
2014-08-07 9:02 ` Marat Zakirov
2014-08-07 13:52 ` Marat Zakirov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E384A8.2090705@samsung.com \
--to=m.zakirov@samsung.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rearnsha@arm.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).