From: Sylvestre Ledru <sylvestre@debian.org>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>
Subject: Re: [Patch] PR55189 enable -Wreturn-type by default
Date: Mon, 11 Aug 2014 07:44:00 -0000 [thread overview]
Message-ID: <53E8744B.5030509@debian.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1407302205070.3490@digraph.polyomino.org.uk>
On 31/07/2014 00:08, Joseph S. Myers wrote:
> On Mon, 7 Jul 2014, Sylvestre Ledru wrote:
>
>> Hello,
>>
>> On 17/06/2014 19:41, Joseph S. Myers wrote:
>>> On Tue, 17 Jun 2014, Sylvestre Ledru wrote:
>>>
>>>> OK. I will do that.
>>>> We should test the following:
>>>> * default => run just -Wreturn-type
>>>> * -Wreturn-type => Run both
>>>> * -Wreturn-type + -Wmissing-return => Run both
>>>> * -Wno-return-type + -Wmissing-return => Run just the second one
>>>> * -Wno-return-type + -Wno-missing-return => Run none
>>>> Do you see any other?
>>> That looks like the right things to test, if there are no changes for
>>> anything other than those options.
>> Here it is:
>> https://github.com/sylvestre/gcc/commit/db8aaac91aa09fd1ec1cc8974586aec45a221e71
>>
>> Is that what you expected?
> The test Wmissing-return2.c only has one of the two warnings. But as per
> "-Wreturn-type => Run both", and for backwards compatibility with the
> existing definition of -Wreturn-type, both warnings should appear for this
> test.
Make sense. Thanks for the feedback and the help.
Here it is:
https://github.com/sylvestre/gcc/commit/089ffc9fb85034111b892ee10190dc12b5dbe551
> (It's simply that only a subset of -Wreturn-type seems suitable to
> enable by default for C. Maybe the default subset, -Wreturn-type
> -Wno-missing-return (which is a combination that should also be included
> in the testcases), should have its own option name, although I don't know
> what that would be.)
>
What about implementing that in an further commit?
I have touched more than 1200 test files and I would like to see that
merged soon to avoid more conflicts.
By the way, do you prefer a single commit for all tests or one per
directory (gfortran, C++, gcc, OpenMP) ?
Thanks
Sylvestre
next prev parent reply other threads:[~2014-08-11 7:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:49 Sylvestre Ledru
2014-06-04 22:35 ` Mike Stump
2014-06-04 23:31 ` Joseph S. Myers
2014-06-05 9:33 ` Sylvestre Ledru
2014-06-05 18:01 ` Joseph S. Myers
2014-06-17 16:52 ` Sylvestre Ledru
2014-06-17 17:15 ` Joseph S. Myers
2014-06-17 17:37 ` Sylvestre Ledru
2014-06-17 17:41 ` Joseph S. Myers
2014-07-07 17:18 ` Sylvestre Ledru
2014-07-20 19:20 ` Sylvestre Ledru
2014-07-30 22:10 ` Joseph S. Myers
2014-08-11 7:44 ` Sylvestre Ledru [this message]
2014-08-12 17:49 ` Joseph S. Myers
2014-08-12 17:53 ` Sylvestre Ledru
2014-08-14 17:01 ` Sylvestre Ledru
-- strict thread matches above, loose matches on Subject: below --
2014-08-14 18:49 Manuel López-Ibáñez
2014-08-15 16:28 ` Sylvestre Ledru
2014-08-19 22:03 ` Joseph S. Myers
2014-08-20 21:42 ` Sylvestre Ledru
2014-08-20 21:58 ` Joseph S. Myers
2013-12-20 17:54 Sylvestre Ledru
2013-12-27 5:26 ` Chung-Ju Wu
2013-12-27 5:32 ` Yury Gribov
2014-01-14 17:49 ` Sylvestre Ledru
2014-01-16 19:44 ` Jason Merrill
2014-01-23 6:44 ` Sylvestre Ledru
2014-01-23 18:48 ` Jason Merrill
2014-01-23 18:57 ` Sylvestre Ledru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E8744B.5030509@debian.org \
--to=sylvestre@debian.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).