From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19546 invoked by alias); 11 Aug 2014 07:44:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19534 invoked by uid 89); 11 Aug 2014 07:44:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC,TVD_RCVD_IP autolearn=no version=3.3.2 X-HELO: batou.ecranbleu.org Received: from 195-154-220-89.rev.poneytelecom.eu (HELO batou.ecranbleu.org) (195.154.220.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Aug 2014 07:44:15 +0000 Received: by batou.ecranbleu.org (Postfix, from userid 999) id BFA25122DDE; Mon, 11 Aug 2014 09:44:15 +0200 (CEST) Received: from [192.168.12.5] (unknown [192.168.12.5]) (Authenticated sender: sylvestredeb@ledru.info) by batou.ecranbleu.org (Postfix) with ESMTPSA id A589E120783; Mon, 11 Aug 2014 09:44:14 +0200 (CEST) Message-ID: <53E8744B.5030509@debian.org> Date: Mon, 11 Aug 2014 07:44:00 -0000 From: Sylvestre Ledru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gcc-patches@gcc.gnu.org, Jason Merrill Subject: Re: [Patch] PR55189 enable -Wreturn-type by default References: <538F7856.1090104@debian.org> <53903961.9030501@debian.org> <53A07226.4040803@debian.org> <53A07CCC.2030004@debian.org> <53BAD646.7020102@debian.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00990.txt.bz2 On 31/07/2014 00:08, Joseph S. Myers wrote: > On Mon, 7 Jul 2014, Sylvestre Ledru wrote: > >> Hello, >> >> On 17/06/2014 19:41, Joseph S. Myers wrote: >>> On Tue, 17 Jun 2014, Sylvestre Ledru wrote: >>> >>>> OK. I will do that. >>>> We should test the following: >>>> * default => run just -Wreturn-type >>>> * -Wreturn-type => Run both >>>> * -Wreturn-type + -Wmissing-return => Run both >>>> * -Wno-return-type + -Wmissing-return => Run just the second one >>>> * -Wno-return-type + -Wno-missing-return => Run none >>>> Do you see any other? >>> That looks like the right things to test, if there are no changes for >>> anything other than those options. >> Here it is: >> https://github.com/sylvestre/gcc/commit/db8aaac91aa09fd1ec1cc8974586aec45a221e71 >> >> Is that what you expected? > The test Wmissing-return2.c only has one of the two warnings. But as per > "-Wreturn-type => Run both", and for backwards compatibility with the > existing definition of -Wreturn-type, both warnings should appear for this > test. Make sense. Thanks for the feedback and the help. Here it is: https://github.com/sylvestre/gcc/commit/089ffc9fb85034111b892ee10190dc12b5dbe551 > (It's simply that only a subset of -Wreturn-type seems suitable to > enable by default for C. Maybe the default subset, -Wreturn-type > -Wno-missing-return (which is a combination that should also be included > in the testcases), should have its own option name, although I don't know > what that would be.) > What about implementing that in an further commit? I have touched more than 1200 test files and I would like to see that merged soon to avoid more conflicts. By the way, do you prefer a single commit for all tests or one per directory (gfortran, C++, gcc, OpenMP) ? Thanks Sylvestre