From: Joel Sherrill <joel.sherrill@oarcorp.com>
To: Arnaud Charlet <charlet@adacore.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C
Date: Tue, 12 Aug 2014 19:20:00 -0000 [thread overview]
Message-ID: <53EA68E7.2000205@oarcorp.com> (raw)
In-Reply-To: <20140812173351.GB17938@adacore.com>
On 8/12/2014 12:33 PM, Arnaud Charlet wrote:
>> This didn't get any comments earlier. Is it OK to comment?
> This one is a bit tricky so requires more thoughts. On which targets did
> you test it?
native CentOS and sparc-rtems4.11. I don't have access to much else
except *-rtems* which is basically the same thing with different backend
gcc issues.
The build needs a way to see the RTEMS network .h files since they are
not installed with the libc files. libc/gcc .h files are part of the
normal GNU toolset. The others are part of the BSP install.
>> Somewhere along the way, the Ada run-time Makefile's quit
>> honoring CFLAGS_FOR_TARGET. This just adds it back.
>>
>> 2014-08-12 Joel Sherrill <joel.sherrill@oarcorp.com>
>>
>> * Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C.
> I guess this is OK on principle, but if someone reports an issue with this
> patch, we might need to revert it.
It was in the rts Makefile back when it was under gcc. I suspect it
disappeared when this
all moved to libada. Could check the history if we need to.
> Arno
--
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985
next prev parent reply other threads:[~2014-08-12 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 14:31 Joel Sherrill
2014-08-12 14:31 ` [PATCH 2/2] gcc/ada/socket.c, gsocket.h: Add conditionals for RTEMS Joel Sherrill
2014-08-12 17:32 ` Arnaud Charlet
2014-08-12 17:33 ` [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C Arnaud Charlet
2014-08-12 19:20 ` Joel Sherrill [this message]
2014-08-12 19:23 ` Arnaud Charlet
2014-08-12 19:29 ` Joel Sherrill
2014-08-12 19:30 ` Arnaud Charlet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EA68E7.2000205@oarcorp.com \
--to=joel.sherrill@oarcorp.com \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).