From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15074 invoked by alias); 12 Aug 2014 20:50:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15061 invoked by uid 89); 12 Aug 2014 20:50:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Aug 2014 20:50:41 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7CKoeQE008144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Aug 2014 16:50:40 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7CKodqM002630; Tue, 12 Aug 2014 16:50:39 -0400 Message-ID: <53EA7E1F.1030906@redhat.com> Date: Tue, 12 Aug 2014 20:50:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 001/236] Convert lab_rtx_for_bb from pointer_map_t to pointer_map References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-2-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-2-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01200.txt.bz2 On 08/06/14 11:19, David Malcolm wrote: > This gives a slight improvement in typesafety in cfgexpand.c > > gcc/ > * cfgexpand.c (lab_rtx_for_bb): Convert from pointer_map_t to > pointer_map. > (label_rtx_for_bb): Update for conversion of lab_rtx_for_bb to > a pointer_map, eliminating casts from void* to rtx. > (expand_gimple_basic_block): Likewise. > (pass_expand::execute): Likewise, using new/delete of > pointer_map rathern than pointer_map_create/destroy. NULLify > the lab_rtx_for_bb ptr after deletion for good measure. OK. I think this is still appropriate. It might even still apply cleanly. Seems like this could have gone forward independently of everything else. jeff