From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16510 invoked by alias); 12 Aug 2014 21:59:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16497 invoked by uid 89); 12 Aug 2014 21:59:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Aug 2014 21:59:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7CLxkiR025321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Aug 2014 17:59:46 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7CLxkHG005547; Tue, 12 Aug 2014 17:59:46 -0400 Message-ID: <53EA8E52.9050909@redhat.com> Date: Tue, 12 Aug 2014 21:59:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 018/236] Strengthen return types of various {next|prev}_*insn from rtx to rtx_insn * References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-19-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-19-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01225.txt.bz2 On 08/06/14 11:19, David Malcolm wrote: > These should all eventually require an rtx_insn * as an argument, > but we'll save that for a later patch. > > gcc/ > * rtl.h (previous_insn): Strengthen return type from rtx to > rtx_insn *. > (next_insn): Likewise. > (prev_nonnote_insn): Likewise. > (prev_nonnote_insn_bb): Likewise. > (next_nonnote_insn): Likewise. > (next_nonnote_insn_bb): Likewise. > (prev_nondebug_insn): Likewise. > (next_nondebug_insn): Likewise. > (prev_nonnote_nondebug_insn): Likewise. > (next_nonnote_nondebug_insn): Likewise. > (prev_real_insn): Likewise. > (next_real_insn): Likewise. > (prev_active_insn): Likewise. > (next_active_insn): Likewise. > > * emit-rtl.c (next_insn): Strengthen return type from rtx to > rtx_insn *, adding a checked cast. > (previous_insn): Likewise. > (next_nonnote_insn): Likewise. > (next_nonnote_insn_bb): Likewise. > (prev_nonnote_insn): Likewise. > (prev_nonnote_insn_bb): Likewise. > (next_nondebug_insn): Likewise. > (prev_nondebug_insn): Likewise. > (next_nonnote_nondebug_insn): Likewise. > (prev_nonnote_nondebug_insn): Likewise. > (next_real_insn): Likewise. > (prev_real_insn): Likewise. > (next_active_insn): Likewise. > (prev_active_insn): Likewise. > > * config/sh/sh-protos.h (sh_find_set_of_reg): Convert function ptr > param "stepfunc" so that it returns an rtx_insn * rather than an > rtx, to track the change to prev_nonnote_insn_bb, which is the > only function this is called with. > * config/sh/sh.c (sh_find_set_of_reg): Likewise. OK. Jeff