From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10360 invoked by alias); 13 Aug 2014 03:07:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10346 invoked by uid 89); 13 Aug 2014 03:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 03:07:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7D37eT6030454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Aug 2014 23:07:40 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7D37d33024612; Tue, 12 Aug 2014 23:07:39 -0400 Message-ID: <53EAD67B.6090207@redhat.com> Date: Wed, 13 Aug 2014 03:07:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 017/236] Add subclasses for the various kinds of instruction References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-18-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-18-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01235.txt.bz2 On 08/06/14 11:19, David Malcolm wrote: > gcc/ > * coretypes.h (class rtx_real_insn): Add forward declaration. > (class rtx_debug_insn): Likewise. > (class rtx_nonjump_insn): Likewise. > (class rtx_jump_insn): Likewise. > (class rtx_call_insn): Likewise. > (class rtx_jump_table_data): Likewise. > (class rtx_barrier): Likewise. > (class rtx_code_label): Likewise. > (class rtx_note): Likewise. > > * rtl.h (class rtx_real_insn): New, a subclass of rtx_insn, adding > the invariant INSN_P (X). > (class rtx_debug_insn): New, a subclass of rtx_real_insn, adding > the invariant DEBUG_INSN_P (X). > (class rtx_nonjump_insn): New, a subclass of rtx_real_insn, adding > the invariant NONJUMP_INSN_P (X). > (class rtx_jump_insn): New, a subclass of rtx_real_insn, adding > the invariant JUMP_P (X). > (class rtx_call_insn): New, a subclass of rtx_real_insn, adding > the invariant CALL_P (X). > (class rtx_jump_table): New, a subclass of rtx_insn, adding the > invariant JUMP_TABLE_DATA_P (X). > (class rtx_barrier): New, a subclass of rtx_insn, adding the > invariant BARRIER_P (X). > (class rtx_code_label): New, a subclass of rtx_real_insn, adding > the invariant LABEL_P (X). > (class rtx_note): New, a subclass of rtx_real_insn, adding > the invariant NOTE_P(X). > (is_a_helper ::test): New. > (is_a_helper ::test): New. > (is_a_helper ::test): New. > (is_a_helper ::test): New. > (is_a_helper ::test): New. > (is_a_helper ::test): New functions, > overloaded for both rtx and rtx_insn *. > (is_a_helper ::test): New. > (is_a_helper ::test): New functions, overloaded > for both rtx and rtx_insn *. > (is_a_helper ::test): New. Sounds like the direction we're going right now is to drop rtx_real_insn and squish one level of inheritance out. OK with the obvious changes around that. I probably won't call out any rtx_real_insn stuff for future patches as I'll assume you will take care of that as you do your bootstrap builds prior to installation. Jeff