From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14149 invoked by alias); 13 Aug 2014 04:50:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14128 invoked by uid 89); 13 Aug 2014 04:50:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 04:50:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7D4oX23025748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 00:50:33 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7D4oXVK032013; Wed, 13 Aug 2014 00:50:33 -0400 Message-ID: <53EAE0B4.1000903@redhat.com> Date: Wed, 13 Aug 2014 04:50:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 022/236] Make tablejump_p accept a rtx_jump_table_data ** References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-23-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-23-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01241.txt.bz2 On 08/06/14 11:20, David Malcolm wrote: > gcc/ > * rtl.h (tablejump_p): Strengthen third param from rtx * to > rtx_jump_table_data **. > > * cfgbuild.c (make_edges): Introduce local "table", using it in > place of "tmp" for jump table data. > (find_bb_boundaries): Strengthen local "table" from rtx to > rtx_jump_table_data *. > * cfgcleanup.c (merge_blocks_move_successor_nojumps): Likewise. > (outgoing_edges_match): Likewise for locals "table1" and "table2". > (try_crossjump_to_edge): Likewise. > * cfgrtl.c (try_redirect_by_replacing_jump): Likewise for local > "table". > (patch_jump_insn): Introduce local "table", using it in place of > "tmp" for jump table data. > (force_nonfallthru_and_redirect): Introduce local "table", so that > call to tablejump_p can receive an rtx_jump_table_data **. Update > logic around the call to overwrite "note" appropriately if > tablejump_p returns non-zero. > (get_last_bb_insn): Introduce local "table", using it in place of > "tmp" for jump table data. > * dwarf2cfi.c (create_trace_edges): Likewise. > > * config/arm/arm.c (get_jump_table_size): Strengthen param "insn" > from rtx to rtx_jump_table_data *. > (create_fix_barrier): Strengthen local "tmp" from rtx to > rtx_jump_table_data *. > (arm_reorg): Likewise for local "table". > > * config/s390/s390.c (s390_chunkify_start): Likewise. > > * config/spu/spu.c (spu_emit_branch_hint): Likewise. > > * jump.c (delete_related_insns): Strengthen local "lab_next" from > rtx to rtx_jump_table_data *. > > * rtlanal.c (tablejump_p): Strengthen param "tablep" from rtx * to > rtx_jump_table_data **. Add a checked cast when writing through > the pointer: we know there that local "table" is non-NULL and that > JUMP_TABLE_DATA_P (table) holds. > (label_is_jump_target_p): Introduce local "table", using it in > place of "tmp" for jump table data. OK. Jeff