From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9343 invoked by alias); 13 Aug 2014 18:07:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9333 invoked by uid 89); 13 Aug 2014 18:07:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 18:07:15 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7DI7D7f014789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 14:07:13 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7DI7Db6015021; Wed, 13 Aug 2014 14:07:13 -0400 Message-ID: <53EBA951.5090705@redhat.com> Date: Wed, 13 Aug 2014 18:07:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 044/236] Pass "insn" as an rtx_insn within generated get_attr_ fns in insn-attrtab.c References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-45-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-45-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01354.txt.bz2 On 08/06/14 11:20, David Malcolm wrote: > Strengthen "insn" from rtx to rtx_insn * within the generated get_attr_ > functions in insn-attrtab.c, without imposing a strengthening from rtx > to rtx_insn * on the param itself and thus the callers. > > gcc/ > * genattrtab.c (write_attr_get): Within the generated get_attr_ > functions, rename param "insn" to "uncast_insn" and reintroduce > "insn" as an local rtx_insn * using a checked cast, so that "insn" > is an rtx_insn * within insn-attrtab.c OK. Jeff